util: fix indentationLvl when exceeding max call stack size #22787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The inspection indentation level was not always reset to it's former value in case the maximum call stack size was exceeded.
nodejs-github-bot
added
the
util
jasnell
approved these changes
Sep 10, 2018
BridgeAR
added
the
author ready
|
@nodejs/util PTAL |
|
Landed in 08d983c |
BridgeAR
added a commit
to BridgeAR/node
that referenced
this pull request
Sep 13, 2018
The inspection indentation level was not always reset to it's former value in case the maximum call stack size was exceeded. PR-URL: nodejs#22787 Reviewed-By: James M Snell <[email protected]>
|
Should this be backported to |
targos
pushed a commit
to targos/node
that referenced
this pull request
Sep 23, 2018
The inspection indentation level was not always reset to it's former value in case the maximum call stack size was exceeded. PR-URL: nodejs#22787 Reviewed-By: James M Snell <[email protected]>
targos
pushed a commit
that referenced
this pull request
Sep 24, 2018
The inspection indentation level was not always reset to it's former value in case the maximum call stack size was exceeded. Backport-PR-URL: #23039 PR-URL: #22787 Reviewed-By: James M Snell <[email protected]>
targos
added
backported-to-v10.x
and removed
author ready
This was referenced Oct 10, 2018
This was referenced Oct 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The inspection indentation level was not always reset to it's former
value in case the maximum call stack size was exceeded.
It did not seem to be critical to add a test case for this as it's a pretty
special case that has no completely reliable output anyway (the stack
limit is not going to be identical on each run).
Please let me know if you feel I should add a test nevertheless.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes