Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: add missing package-lock to clang-format #22500

Closed
wants to merge 1 commit into from
Closed

tools: add missing package-lock to clang-format #22500

wants to merge 1 commit into from

Conversation

targos
Copy link
Member

@targos targos commented Aug 24, 2018

npm ci fails where there is no package-lock.json.
Also add the node_modules directory to .gitignore.

@targos
tools: add missing package-lock to clang-format
57b8bd5 
`npm ci` fails where there is no package-lock.json.
Also add the `node_modules` directory to .gitignore.
@targos targos added tools Issues and PRs related to the tools directory. fast-track PRs that do not need to wait for 48 hours to land. labels Aug 24, 2018
@nodejs-github-bot
Copy link
Collaborator

@targos build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/658/pipeline

@nodejs-github-bot nodejs-github-bot added meta Issues and PRs related to the general management of the project. tools Issues and PRs related to the tools directory. labels Aug 24, 2018
@targos
Copy link
Member Author

targos commented Aug 24, 2018

Please 👍 this comment to fast-track.

@targos
Copy link
Member Author

targos commented Aug 24, 2018

The lite pipeline CI should be enough for this change.

@refack refack mentioned this pull request Aug 24, 2018
Closed
2 tasks
@refack
Copy link
Contributor

refack commented Aug 24, 2018

Dup of #22481 😄

@targos
Copy link
Member Author

targos commented Aug 24, 2018

@refack oops sorry! I only searched for "clang-format"

@refack
Copy link
Contributor

refack commented Aug 24, 2018

@refack oops sorry! I only searched for "clang-format"

Well I missed the .gitignore so this is better.

@addaleax
Copy link
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/16723/

@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Aug 24, 2018
@addaleax
Copy link
Member

ARM re-build: https://ci.nodejs.org/job/node-test-commit-arm-fanned/3198/

@addaleax
Copy link
Member

Again: https://ci.nodejs.org/job/node-test-commit-arm-fanned/3209/

@targos
Copy link
Member Author

targos commented Aug 25, 2018

Again: https://ci.nodejs.org/job/node-test-commit-arm-fanned/3219/

targos added a commit to targos/node that referenced this pull request Aug 25, 2018
@targos
tools: add missing package-lock to clang-format
e10290c 
`npm ci` fails where there is no package-lock.json.
Also add the `node_modules` directory to .gitignore.

PR-URL: nodejs#22500
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@targos
Copy link
Member Author

targos commented Aug 25, 2018

Landed in e10290c

@targos targos closed this Aug 25, 2018
@targos targos deleted the clang-format-npm branch August 25, 2018 15:11
addaleax pushed a commit that referenced this pull request Aug 27, 2018
@targos @addaleax
tools: add missing package-lock to clang-format
83cbb7d 
`npm ci` fails where there is no package-lock.json.
Also add the `node_modules` directory to .gitignore.

PR-URL: #22500
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: James M Snell <[email protected]>
targos added a commit that referenced this pull request Sep 3, 2018
@targos
tools: add missing package-lock to clang-format
14ac77e 
`npm ci` fails where there is no package-lock.json.
Also add the `node_modules` directory to .gitignore.

PR-URL: #22500
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@targos targos mentioned this pull request Sep 5, 2018
Merged
targos added a commit that referenced this pull request Sep 6, 2018
@targos
tools: add missing package-lock to clang-format
2e0652d 
`npm ci` fails where there is no package-lock.json.
Also add the `node_modules` directory to .gitignore.

PR-URL: #22500
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: James M Snell <[email protected]>
This was referenced Sep 6, 2018
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trivikr trivikr trivikr approved these changes

@cjihrig cjihrig cjihrig approved these changes

@lpinca lpinca lpinca approved these changes

@jasnell jasnell jasnell approved these changes

@danbev danbev danbev approved these changes

@refack refack refack approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. meta Issues and PRs related to the general management of the project. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@targos @nodejs-github-bot @refack @addaleax @danbev @jasnell @lpinca @cjihrig @trivikr