Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(v10.x backport) crypto: add support for OCB mode for AEAD #22473

Closed
wants to merge 1 commit into from
Closed

(v10.x backport) crypto: add support for OCB mode for AEAD #22473

wants to merge 1 commit into from

Conversation

tniessen
Copy link
Member

Manual backport of #21447.

cc @targos @jasnell @nodejs/crypto

@tniessen
crypto: add support for OCB mode for AEAD
7ae8ab4 
PR-URL: nodejs#21447
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@nodejs-github-bot
Copy link
Collaborator

@tniessen build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/638/pipeline

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. v10.x labels Aug 23, 2018
@targos
Copy link
Member

targos commented Aug 24, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/16728/

targos
targos approved these changes Aug 24, 2018
View reviewed changes
Copy link
Member

@targos targos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@addaleax
Copy link
Member

New CI: https://ci.nodejs.org/job/node-test-pull-request/16811/

@targos
Copy link
Member

targos commented Aug 28, 2018

New CI: https://ci.nodejs.org/job/node-test-pull-request/16833/

@addaleax
Copy link
Member

Again: https://ci.nodejs.org/job/node-test-pull-request/16836/

@targos
Copy link
Member

targos commented Aug 29, 2018 •
edited
Loading

Landed in bc7dbc1

@targos targos closed this Aug 29, 2018
targos pushed a commit that referenced this pull request Aug 29, 2018
@tniessen @targos
crypto: add support for OCB mode for AEAD
bc7dbc1 
Backport-PR-URL: #22473
PR-URL: #21447
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
targos pushed a commit that referenced this pull request Sep 3, 2018
@tniessen @targos
crypto: add support for OCB mode for AEAD
59a6c60 
Backport-PR-URL: #22473
PR-URL: #21447
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
targos pushed a commit that referenced this pull request Sep 6, 2018
@tniessen @targos
crypto: add support for OCB mode for AEAD
6465623 
Backport-PR-URL: #22473
PR-URL: #21447
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@targos targos targos approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tniessen @nodejs-github-bot @targos @addaleax