deps: cherry-pick 9a23bdd from upstream V8 #22338
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
build
mmarchini
approved these changes
Aug 15, 2018
|
@nodejs/v8 @nodejs/v8-update PTAL. Is there any chance we can backport this upstream to 6.8? |
|
The process to request an merge to an active upstream upstream branch is documented here. Specifically:
I've gone ahead and done the above. |
Original commit message:
[Isolate] Fix Isolate::PrintCurrentStackTrace for interpreted frames
Previously we were getting the code object from the stack, so printed incorrect
position details for interpreted frames.
BUG=v8:7916
Change-Id: I2f87584117d88b7db3f3b9bdbfe793c4d3e33fe9
Reviewed-on: https://chromium-review.googlesource.com/1126313
Reviewed-by: Toon Verwaest <[email protected]>
Commit-Queue: Ross McIlroy <[email protected]>
Cr-Commit-Position: refs/heads/master@{nodejs#54253}
Refs: v8/v8@9a23bdd
Fixes: nodejs#21988
Drieger
force-pushed
the
stack_trace_with_abort_flag
branch
from
74d552a
to
8b7def0
Compare
|
Commit has landed in 6.9 |
BethGriggs
pushed a commit
that referenced
this pull request
Oct 2, 2018
Original commit message:
[Isolate] Fix Isolate::PrintCurrentStackTrace for interpreted frames
Previously we were getting the code object from the stack, so printed incorrect
position details for interpreted frames.
BUG=v8:7916
Change-Id: I2f87584117d88b7db3f3b9bdbfe793c4d3e33fe9
Reviewed-on: https://chromium-review.googlesource.com/1126313
Reviewed-by: Toon Verwaest <[email protected]>
Commit-Queue: Ross McIlroy <[email protected]>
Cr-Commit-Position: refs/heads/master@{#54253}
Refs: v8/v8@9a23bdd
Fixes: #21988
PR-URL: #22418
Refs: #22338
Reviewed-By: Matheus Marchini <[email protected]>
Reviewed-By: Ujjwal Sharma <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original commit message:
Refs: v8/v8@9a23bdd
Fixes: #21988
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes