Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

util: improve empty typed array inspection #22284

Closed
wants to merge 3 commits into from
Closed

util: improve empty typed array inspection #22284

wants to merge 3 commits into from

Conversation

BridgeAR
Copy link
Member

They should be aligned with all other empty objects. Therefore the
whitespace is removed and they got a fast path for that.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@BridgeAR
util: improve empty typed array inspection
ae300c6 
They should be aligned with all other empty objects. Therefore the
whitespace is removed and they got a fast path for that.
@nodejs-github-bot
Copy link
Collaborator

@BridgeAR build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/535/pipeline

@nodejs-github-bot nodejs-github-bot added the util Issues and PRs related to the built-in util module. label Aug 12, 2018
@jasnell
Copy link
Member

jasnell commented Aug 12, 2018 •
edited
Loading

I really don't want this to be semver-major but the output change may require it. Thoughts @nodejs/tsc?

devsnek
devsnek approved these changes Aug 12, 2018
View reviewed changes
Copy link
Member

@devsnek devsnek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm without semver-major. the docs explicitly say not to use the output of util.inspect programmatically.

addaleax
addaleax approved these changes Aug 12, 2018
View reviewed changes
Copy link
Member

@addaleax addaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think in this case it’s okay to land it as a non-breaking change if CITGM is okay with it.

(I’d generally keep it a case-by-case decision, though.)

@BridgeAR
Copy link
Member Author

CI https://ci.nodejs.org/job/node-test-pull-request/16407/

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Aug 13, 2018
@BridgeAR
Copy link
Member Author

I just pushed another commit to prevent this path from being taken in case showHidden is set to true.

CI https://ci.nodejs.org/job/node-test-pull-request/16428/

@joyeecheung joyeecheung mentioned this pull request Aug 15, 2018
Closed
dnalborczyk pushed a commit to dnalborczyk/node that referenced this pull request Aug 15, 2018
@BridgeAR
util: improve empty typed array inspection
db6a246 
They should be aligned with all other empty objects. Therefore the
whitespace is removed and they got a fast path for that.

PR-URL: nodejs#22284
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
@BridgeAR
Copy link
Member Author

CITGM this PR https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1509/
CITGM other PR https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1507/

@BridgeAR
Copy link
Member Author

CITGM runs came out fine.

@BridgeAR
Copy link
Member Author

Landed in db6a246

@BridgeAR BridgeAR closed this Aug 15, 2018
@targos targos added backport-requested-v10.x and removed author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Aug 19, 2018
@targos
Copy link
Member

targos commented Aug 19, 2018

Should this be backported to v10.x-staging? If yes please follow the guide and raise a backport PR, if not let me know or add the dont-land-on label.

@targos
Copy link
Member

targos commented Aug 19, 2018

Landed easily after #21869

targos pushed a commit that referenced this pull request Aug 19, 2018
@BridgeAR @targos
util: improve empty typed array inspection
9bfe4c7 
They should be aligned with all other empty objects. Therefore the
whitespace is removed and they got a fast path for that.

PR-URL: #22284
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
targos pushed a commit that referenced this pull request Sep 3, 2018
@BridgeAR @targos
util: improve empty typed array inspection
3dc3a31 
They should be aligned with all other empty objects. Therefore the
whitespace is removed and they got a fast path for that.

PR-URL: #22284
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
@targos targos mentioned this pull request Sep 5, 2018
Merged
@beevelop beevelop mentioned this pull request Sep 6, 2018
Closed
@beevelop beevelop mentioned this pull request Sep 6, 2018
Closed
@BridgeAR BridgeAR deleted the fast-empty-typedarray branch January 20, 2020 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trivikr trivikr trivikr approved these changes

@devsnek devsnek devsnek approved these changes

@JungMinu JungMinu JungMinu approved these changes

@lpinca lpinca lpinca approved these changes

@addaleax addaleax addaleax approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
util Issues and PRs related to the built-in util module.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@BridgeAR @nodejs-github-bot @jasnell @targos @addaleax @lpinca @JungMinu @devsnek @trivikr