url: move process.binding('url') to internalBinding

[starkwang]

Refs: #22160

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• commit message follows commit guidelines

[nodejs-github-bot]

@starkwang build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/470/pipeline

[starkwang]

CI: https://ci.nodejs.org/job/node-test-pull-request/16293/

[maclover7]

CITGM: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1495/

[maclover7]

Hmm, here's looks like [email protected] is failing on an Ubuntu 16.04 machine (I double checked the git sha and that process.binding('url') threw an error to make sure things were recompiled properly):

 internal/url.js:1441
 setURLConstructor(constructUrl);
 ^
 TypeError: setURLConstructor is not a function
     at internal/url.js:1441:1
     at req_ (/home/iojs/build/workspace/citgm-smoker/nodes/ubuntu1604-64/citgm_tmp/92109405-f794-4108-8120-36349a9efdfa/gulp/node_modules/natives/index.js:137:5)
     at require (/home/iojs/build/workspace/citgm-smoker/nodes/ubuntu1604-64/citgm_tmp/92109405-f794-4108-8120-36349a9efdfa/gulp/node_modules/natives/index.js:110:12)
     at fs.js:57:28
     at req_ (/home/iojs/build/workspace/citgm-smoker/nodes/ubuntu1604-64/citgm_tmp/92109405-f794-4108-8120-36349a9efdfa/gulp/node_modules/natives/index.js:137:5)
     at Object.req [as require] (/home/iojs/build/workspace/citgm-smoker/nodes/ubuntu1604-64/citgm_tmp/92109405-f794-4108-8120-36349a9efdfa/gulp/node_modules/natives/index.js:54:10)
     at Object.<anonymous> (/home/iojs/build/workspace/citgm-smoker/nodes/ubuntu1604-64/citgm_tmp/92109405-f794-4108-8120-36349a9efdfa/gulp/node_modules/graceful-fs/fs.js:1:99)

edit: is also failing on Debian 8 x64, Debian 8 x86, Debian 9, and Fedora 26

[jasnell]

The failure in gulp makes sense given it's dependency on natives, which uses process.binding() or {} as a fallback. Generally speaking, anything that depends on natives is going to be broken by the transition away from process.binding(), which is one of the fundamental problems we're going to have moving forward with this transition.

[jasnell]

This one should not land yet because of the natives failure. It is unfortunate, but we should hold off a bit on process.binding() changes that impact the fs module directly.

[devsnek]

@jasnell this is okay with #22269 right?

[jasnell]

Potentially yes. We should still be careful.

[jdalton]

Holding removals until migration is ironed out

[jasnell]

@starkwang ... when you get a moment, can you rebase this on master then apply the following patch that will be required for this to proceed:

Author: James M Snell <[email protected]>
Date:   Tue Aug 14 19:36:25 2018 -0700

    [Squash] add `process.binding('url')` to fallthrough whitelist

diff --git a/lib/internal/bootstrap/node.js b/lib/internal/bootstrap/node.js
index 08daeb1915..ffae6e4cd9 100644
--- a/lib/internal/bootstrap/node.js
+++ b/lib/internal/bootstrap/node.js
@@ -327,7 +327,7 @@
     // that are whitelisted for access via process.binding()... this is used
     // to provide a transition path for modules that are being moved over to
     // internalBinding.
-    const internalBindingWhitelist = new SafeSet(['uv']);
+    const internalBindingWhitelist = new SafeSet(['uv', 'url']);
     process.binding = function binding(name) {
       return internalBindingWhitelist.has(name) ?
         internalBinding(name) :
diff --git a/test/parallel/test-process-binding-internalbinding-whitelist.js b/test/parallel/test-process-binding-internalbinding-whitelist.js
index ece967a0b7..cc0119917d 100644
--- a/test/parallel/test-process-binding-internalbinding-whitelist.js
+++ b/test/parallel/test-process-binding-internalbinding-whitelist.js
@@ -7,3 +7,4 @@ const assert = require('assert');
 // Assert that whitelisted internalBinding modules are accessible via
 // process.binding().
 assert(process.binding('uv'));
+assert(process.binding('url'));

[starkwang]

The branch has been rebased on master and applied the patch.

[starkwang]

Umm... I can't open a new CI for this because it is blocked by nodejs/build#1442.

[jasnell]

Yep, no worries... once the release happens the CI will be unrestricted again.

[starkwang]

New CI: https://ci.nodejs.org/job/node-test-pull-request/16488/

[starkwang]

Rebased branch to resolve conflicts.

[jasnell]

CI: https://ci.nodejs.org/job/node-test-pull-request/16618/

[jasnell]

Ugh, another unrelated CI failure... resuming: https://ci.nodejs.org/job/node-test-pull-request/16621/

[BridgeAR]

This needs a rebase.

[starkwang]

Rebased and opened a new CI: https://ci.nodejs.org/job/node-test-pull-request/17058/

[starkwang]

Landed in e917a23.