Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: provide better message for orphan output documentation #21913

Closed
wants to merge 2 commits into from
Closed

test: provide better message for orphan output documentation #21913

wants to merge 2 commits into from

Conversation

rubys
Copy link
Member

@rubys rubys commented Jul 20, 2018

Fixes #21912

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@vsemozhetbyt vsemozhetbyt added doc Issues and PRs related to the documentations. test Issues and PRs related to the tests. tools Issues and PRs related to the tools directory. labels Jul 20, 2018
@vsemozhetbyt

This comment has been minimized.

Sign in to view
@Trott
Copy link
Member

Trott commented Jul 20, 2018

Optional additional improvement for the output: There's a not not on line 57 (line 46 in the current version of the file). I think just one not is intended.

@vsemozhetbyt
Copy link
Contributor

CI-lite: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/332/

Trott pushed a commit to Trott/io.js that referenced this pull request Jul 23, 2018
@rubys @Trott
test: provide better message for orphan output documentation
c57e11c 
PR-URL: nodejs#21913
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@Trott
Copy link
Member

Trott commented Jul 23, 2018

Landed in c57e11c

@Trott Trott closed this Jul 23, 2018
targos pushed a commit that referenced this pull request Jul 24, 2018
@rubys @targos
test: provide better message for orphan output documentation
3213c09 
PR-URL: #21913
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@lundibundi lundibundi mentioned this pull request Jul 26, 2018
Closed
@targos targos mentioned this pull request Jul 31, 2018
Merged
This was referenced Aug 1, 2018
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trivikr trivikr trivikr approved these changes

@vsemozhetbyt vsemozhetbyt vsemozhetbyt approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@cjihrig cjihrig cjihrig approved these changes

@Trott Trott Trott approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. test Issues and PRs related to the tests. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

test: unclear error with _toc.html
7 participants
@rubys @vsemozhetbyt @Trott @jasnell @cjihrig @BridgeAR @trivikr