Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http2: simplify custom promisify #21835

Closed
wants to merge 1 commit into from

Conversation

BridgeAR
Copy link
Member

This is just a small refactoring.

Refs: #20830 (comment)

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

This is just a small refactoring.

Refs: nodejs#20830 (comment)
@BridgeAR BridgeAR requested a review from TimothyGu July 16, 2018 15:45
@nodejs-github-bot nodejs-github-bot added dont-land-on-v4.x http2 Issues or PRs related to the http2 subsystem. labels Jul 16, 2018
@BridgeAR BridgeAR added the fast-track PRs that do not need to wait for 48 hours to land. label Jul 16, 2018
Copy link
Member

@addaleax addaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this changes semantics -- previously, it would resolve the Promise once the connection is established, now it does so immediately.
I think the former is the expected behaviour here.

@addaleax addaleax removed the fast-track PRs that do not need to wait for 48 hours to land. label Jul 16, 2018
@BridgeAR
Copy link
Member Author

@addaleax true. Even though there is another way of doing it that would still be more straight forward, I do not really think that it has to be changed. I just tried to follow up on the request. Closing therefore.

@BridgeAR BridgeAR closed this Jul 17, 2018
@BridgeAR BridgeAR deleted the simplify-custom-promisify branch January 20, 2020 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
http2 Issues or PRs related to the http2 subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants