test: check option start or end is not safe integer #21704
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To increase fs readstream coverage, added test to check error when option.start or end is not safe integer.
fhinkel
approved these changes
Jul 8, 2018
claudiorodriguez
approved these changes
Jul 8, 2018
starkwang
approved these changes
Jul 9, 2018
lpinca
approved these changes
Jul 9, 2018
cjihrig
approved these changes
Jul 10, 2018
jasnell
approved these changes
Jul 10, 2018
|
Landed in 1f16758 🎉 |
addaleax
pushed a commit
that referenced
this pull request
Jul 10, 2018
To increase fs readstream coverage, added test to check error when option.start or end is not safe integer. PR-URL: #21704 Reviewed-By: Franziska Hinkelmann <[email protected]> Reviewed-By: Claudio Rodriguez <[email protected]> Reviewed-By: Weijia Wang <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
|
Depends on a major change: #19898. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To increase fs readstream coverage, added test to check error when
option.start or end is not safe integer.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes