test: add test for dns.promises.resolve #21691
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasnell
approved these changes
Jul 10, 2018
|
Landed in 3898abc 🎉 |
addaleax
pushed a commit
that referenced
this pull request
Jul 10, 2018
PR-URL: #21691 Reviewed-By: Weijia Wang <[email protected]> Reviewed-By: James M Snell <[email protected]>
targos
pushed a commit
that referenced
this pull request
Jul 12, 2018
PR-URL: #21691 Reviewed-By: Weijia Wang <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
This was referenced Jul 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added test for dns.promises.resolve.
This improves the test coverage of dns.promises.resolve.
https://coverage.nodejs.org/coverage-e55bdde92513ecf4/root/internal/dns/promises.js.html#L229
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes