doc: add links to inline HTML table #21678
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
crypto
Links in crypto.md table have been autolinking, but correct Markdown processing will not autolink in block elements like tables. Upcoming marked 0.4.0 will not autolink in this instance, so add the links as anchor elements.
vsemozhetbyt
approved these changes
Jul 6, 2018
vsemozhetbyt
added
the
author ready
|
Strange md-lint failure for a different doc. |
|
Node.js Collaborators, please, add 👍 here if you approve fast-tracking. |
|
That md lint failure could happen if the linter is using a previous version of the prohibited-strings plugin. Not sure how/why that would happen. Let's try running a lite CI again: https://ci.nodejs.org/job/node-test-pull-request/15748/ EDIT: Oops, I accidentally did full CI rather than lite CI. ¯\(ツ)/¯ |
|
More on that lint failure: Something odd must have happened with the rebase or something because the job says it is for changes by me and Gus Caplan but this PR is only me. Might be a problem with the way the auto-start job works? @nodejs/build |
lpinca
approved these changes
Jul 6, 2018
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Jul 6, 2018
Links in crypto.md table have been autolinking, but correct Markdown processing will not autolink in block elements like tables. Upcoming marked 0.4.0 will not autolink in this instance, so add the links as anchor elements. PR-URL: nodejs#21678 Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
|
Landed in dd023df |
targos
pushed a commit
that referenced
this pull request
Jul 8, 2018
Links in crypto.md table have been autolinking, but correct Markdown processing will not autolink in block elements like tables. Upcoming marked 0.4.0 will not autolink in this instance, so add the links as anchor elements. PR-URL: #21678 Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Merged
This was referenced Jul 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Links in crypto.md table have been autolinking, but correct
Markdown processing will not autolink in block elements like tables.
Upcoming marked 0.4.0 will not autolink in this instance, so add the
links as anchor elements.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes