test: fix args passed to strictEqual #21584
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Commit message prefix should just be |
The third argument passed to asert.strictEqual() displays the message passed as third argument and does not report the difference between actual and expected if the test is failing. Hence, the third argument has been removed.
aitchkhan
force-pushed
the
fix-immediate-timer-que-test
branch
from
9983ffa
to
b50a6e6
Compare
Trott
added
author ready
|
👍 this comment for fast-tracking. |
mscdex
changed the title
addaleax
approved these changes
Jun 29, 2018
cjihrig
approved these changes
Jun 29, 2018
lpinca
approved these changes
Jun 29, 2018
jasnell
approved these changes
Jun 29, 2018
|
Lone CI failure is a known issue that was fixed in the last hour. Running a Resume Build on node-test-pull-request to re-run just the task that failed: |
trivikr
approved these changes
Jul 1, 2018
trivikr
pushed a commit
that referenced
this pull request
Jul 4, 2018
The third argument passed to asert.strictEqual() displays the message passed as third argument and does not report the difference between actual and expected if the test is failing. Hence, the third argument has been removed. PR-URL: #21584 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
|
Landed in 24ee745 Congratulations @aitchkhan on your first commit in Node.js core! 🎉🎉🎉 |
targos
pushed a commit
that referenced
this pull request
Jul 4, 2018
The third argument passed to asert.strictEqual() displays the message passed as third argument and does not report the difference between actual and expected if the test is failing. Hence, the third argument has been removed. PR-URL: #21584 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
Merged
This was referenced Jul 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The third argument passed to asert.strictEqual() displays the message
passed as third argument and does not report the difference between
actual and expected if the test is failing.
Hence, the third argument has been removed.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes