Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: build addons in parallel on Windows #21403

Closed
wants to merge 1 commit into from
Closed

build: build addons in parallel on Windows #21403

wants to merge 1 commit into from

Conversation

bzoz
Copy link
Contributor

@bzoz bzoz commented Jun 19, 2018

Port #21155 to vcbuild.bat

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

/cc @addaleax @nodejs/build-files @nodejs/platform-windows

@nodejs-github-bot
Copy link
Collaborator

@bzoz build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/97/pipeline

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. windows Issues and PRs related to the Windows platform. labels Jun 19, 2018
@bzoz
Copy link
Contributor Author

bzoz commented Jun 19, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/15522/

@bzoz
Copy link
Contributor Author

bzoz commented Jun 19, 2018

On my box this reduces addon build time from 100 to 40 seconds.

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jun 20, 2018
richardlau
richardlau reviewed Jun 21, 2018
View reviewed changes
vcbuild.bat
setlocal
set npm_config_nodedir=%~dp0
"%node_exe%" "%~dp0tools\build-addons.js" "%~dp0deps\npm\node_modules\node-gyp\bin\node-gyp.js" "%~dp0test\addons"
if errorlevel 1 exit /b 1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be a neq 0 test like the code block it replaces?

Copy link
Contributor

@refack refack Jun 21, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is more CMD idiomatic (https://ss64.com/nt/if.html): if errorlevel NUM checks if %errorlevel% if equal or greater then NUM (notice errorlevel is not dereferenced with % or !!)

But AFAIK the last 1 is unnecessary (exit /b will propagate the errorlevel). https://ss64.com/nt/exit.html

EXIT without an ExitCode acts the same as goto:eof and will not alter the %ERRORLEVEL%

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can errorlevel be negative?

addaleax
addaleax approved these changes Jun 22, 2018
View reviewed changes
Copy link
Member

@addaleax addaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I think we want the same thing for the N-API addons?

@apapirovski
Copy link
Member

Landed in c403eeb

apapirovski pushed a commit that referenced this pull request Jun 25, 2018
@bzoz @apapirovski
build: build addons in parallel on Windows
c403eeb 
Port #21155 to vcbuild.bat

PR-URL: #21403
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
targos pushed a commit that referenced this pull request Jun 25, 2018
@bzoz @targos
build: build addons in parallel on Windows
6f80e30 
Port #21155 to vcbuild.bat

PR-URL: #21403
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
@targos targos mentioned this pull request Jul 3, 2018
Merged
bzoz added a commit to JaneaSystems/node that referenced this pull request Aug 29, 2018
@bzoz
win,build: build N-API addons in parallel
1e93b47 
Ref: nodejs#21403
@bzoz bzoz mentioned this pull request Aug 29, 2018
Closed
2 tasks
addaleax pushed a commit that referenced this pull request Aug 31, 2018
@bzoz @addaleax
win,build: build N-API addons in parallel
c57ed41 
Ref: #21403

PR-URL: #22582
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
addaleax pushed a commit that referenced this pull request Aug 31, 2018
@bzoz @addaleax
win,build: build N-API addons in parallel
b687c29 
Ref: #21403

PR-URL: #22582
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
targos pushed a commit that referenced this pull request Sep 3, 2018
@bzoz @targos
win,build: build N-API addons in parallel
041c779 
Ref: #21403

PR-URL: #22582
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
targos pushed a commit that referenced this pull request Sep 6, 2018
@bzoz @targos
win,build: build N-API addons in parallel
fbf34d0 
Ref: #21403

PR-URL: #22582
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardlau richardlau richardlau left review comments

@refack refack refack approved these changes

@cjihrig cjihrig cjihrig approved these changes

@addaleax addaleax addaleax approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. build Issues and PRs related to build files or the CI. windows Issues and PRs related to the Windows platform.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@bzoz @nodejs-github-bot @apapirovski @refack @jasnell @addaleax @cjihrig @richardlau @BridgeAR