Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: do proper error checking in AsyncWrap::MakeCallback #21189

Closed
wants to merge 5 commits into from
Closed

src: do proper error checking in AsyncWrap::MakeCallback #21189

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
bbc5258
src: do proper error checking in `AsyncWrap::MakeCallback`
addaleax Jun 7, 2018
4bb9aac
fixup! src: do proper error checking in `AsyncWrap::MakeCallback`
addaleax Jun 7, 2018
032b390
fixup! src: do proper error checking in `AsyncWrap::MakeCallback`
addaleax Jun 7, 2018
c395973
fixup! src: do proper error checking in `AsyncWrap::MakeCallback`
addaleax Jun 11, 2018
fa46748
fixup! src: do proper error checking in `AsyncWrap::MakeCallback`
addaleax Jun 13, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup! src: do proper error checking in AsyncWrap::MakeCallback
  • Loading branch information
@addaleax
addaleax committed Jun 11, 2018

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Learn about vigilant mode
commit 4bb9aac81ce351bf648176d1acfd428881f33ca5
5 changes: 2 additions & 3 deletions test/parallel/test-async-wrap-missing-method.js
View file
Original file line number Diff line number Diff line change
@@ -1,9 +1,8 @@
// Flags: --experimental-worker
'use strict';
const common = require('../common');
const assert = require('assert');
require('../common');

const { MessageChannel, MessagePort } = require('worker_threads');
const { MessageChannel } = require('worker_threads');

{
const { port1, port2 } = new MessageChannel();