Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: remove --expose-http2 option #20887

Closed
wants to merge 2 commits into from
+4 −9
Closed

src: remove --expose-http2 option #20887

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d588480
src: remove --expose-http2 option
danbev May 22, 2018
2a3b629
squash: remove --expose-http2 from benchmarks
danbev May 22, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
src: remove --expose-http2 option 
This commit removes the --expose-http2 option. In the code comment it
states that this should should be noop through v9.x, and it sounds like
it can be removed for 10.x and above.
@danbev
danbev committed May 22, 2018

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
commit d588480b89574cff82f7260cad9f77c4dd4d328c
4 changes: 0 additions & 4 deletions src/node.cc
View file
Original file line number Diff line number Diff line change
@@ -3357,7 +3357,6 @@ static void CheckIfAllowedInEnv(const char* exe, bool is_env,
"--experimental-modules",
"--experimental-repl-await",
"--experimental-vm-modules",
"--expose-http2", // keep as a non-op through v9.x
"--force-fips",
"--icu-data-dir",
"--inspect",
@@ -3607,9 +3606,6 @@ static void ParseArgs(int* argc,
} else if (strcmp(arg, "--expose-internals") == 0 ||
strcmp(arg, "--expose_internals") == 0) {
config_expose_internals = true;
} else if (strcmp(arg, "--expose-http2") == 0 ||
strcmp(arg, "--expose_http2") == 0) {
// Keep as a non-op through v9.x
} else if (strcmp(arg, "-") == 0) {
break;
} else if (strcmp(arg, "--") == 0) {
1 change: 0 additions & 1 deletion test/parallel/test-http2-https-fallback-http-server-options.js
View file
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
// Flags: --expose-http2
'use strict';

const common = require('../common');