Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix tests with symlink #20511

Closed
wants to merge 1 commit into from
Closed

test: fix tests with symlink #20511

wants to merge 1 commit into from

Conversation

shisama
Copy link
Contributor

@shisama shisama commented May 4, 2018 •
edited
Loading

test/README.md indicates that canCreateSymlink in test/common/index.js
always returns true on non-Windows platforms.
Now, this function always returns nothing on non-Windows platforms.

ref: https://github.com/nodejs/node/tree/master/test/common#cancreatesymlink

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

test: fix tests with symlink
a7d1150 
test/README.md indicates that `canCreateSymlink` in test/common/index.js
always returns `true` on non-Windows platforms.
Now, this function always returns nothing on non-Windows platforms.

ref: https://github.com/nodejs/node/tree/master/test/common#cancreatesymlink
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label May 4, 2018
@vsemozhetbyt
Copy link
Contributor

CI: https://ci.nodejs.org/job/node-test-pull-request/14660/

@vsemozhetbyt
Copy link
Contributor

cc @nodejs/testing

@shisama
Copy link
Contributor Author

shisama commented May 4, 2018

Hi @vsemozhetbyt , CI seems to be failing.
Is the cause flaky (#20389)?
Please run CI again.

@vsemozhetbyt
Copy link
Contributor

vsemozhetbyt commented May 4, 2018 •
edited
Loading

AIX task rerun: https://ci.nodejs.org/job/node-test-commit-aix/14725/ (green)

@BridgeAR BridgeAR added fast-track PRs that do not need to wait for 48 hours to land. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels May 5, 2018
cjihrig pushed a commit that referenced this pull request May 5, 2018
@cjihrig
test: fix common.canCreateSymLink() on non-Windows
6ec43fc 
test/common/README.md indicates that canCreateSymlink() always returns
true on non-Windows platforms. However, prior to this commit, undefined
was being returned. This commit aligns the implementation with the
docs by returning true.

PR-URL: #20511
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@cjihrig
Copy link
Contributor

cjihrig commented May 5, 2018

Landed in 6ec43fc. Thanks!

@cjihrig cjihrig closed this May 5, 2018
@shisama shisama deleted the test-fix-symlink-tests branch May 5, 2018 18:43
MylesBorins pushed a commit that referenced this pull request May 8, 2018
@MylesBorins
test: fix common.canCreateSymLink() on non-Windows
0642b6f 
test/common/README.md indicates that canCreateSymlink() always returns
true on non-Windows platforms. However, prior to this commit, undefined
was being returned. This commit aligns the implementation with the
docs by returning true.

PR-URL: #20511
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@MylesBorins MylesBorins mentioned this pull request May 8, 2018
Merged
MylesBorins pushed a commit that referenced this pull request May 8, 2018
@MylesBorins
test: fix common.canCreateSymLink() on non-Windows
73f2dab 
test/common/README.md indicates that canCreateSymlink() always returns
true on non-Windows platforms. However, prior to this commit, undefined
was being returned. This commit aligns the implementation with the
docs by returning true.

PR-URL: #20511
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
MylesBorins pushed a commit that referenced this pull request May 9, 2018
@MylesBorins
test: fix common.canCreateSymLink() on non-Windows
1de67c7 
test/common/README.md indicates that canCreateSymlink() always returns
true on non-Windows platforms. However, prior to this commit, undefined
was being returned. This commit aligns the implementation with the
docs by returning true.

PR-URL: #20511
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BridgeAR BridgeAR BridgeAR approved these changes

@cjihrig cjihrig cjihrig approved these changes

@lpinca lpinca lpinca approved these changes

@refack refack refack approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@shisama @vsemozhetbyt @cjihrig @refack @lpinca @BridgeAR @nodejs-github-bot