child_process: name anonymous functions #20399
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
child_process
BridgeAR
approved these changes
Apr 29, 2018
BridgeAR
added
the
author ready
|
@BridgeAR this should probably be closed, according to #20396 (comment) and #8913 (comment) |
|
@AyushG3112 these are not prototype functions though? I know due to inference most functions will actually already have their names set and this could also be the case here but it should not hurt either. |
trivikr
approved these changes
Apr 29, 2018
|
-1 to fast-tracking (especially on a weekend). No objection to the change though. |
lpinca
approved these changes
Apr 29, 2018
trivikr
pushed a commit
that referenced
this pull request
May 3, 2018
Refs: #8913 PR-URL: #20399 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
|
Landed in c493b98 Congratulations @SerayaEryn on your first commit in Node.js core! 🎉 🎉 🎉 |
MylesBorins
pushed a commit
that referenced
this pull request
May 4, 2018
Refs: #8913 PR-URL: #20399 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
May 8, 2018
Refs: #8913 PR-URL: #20399 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: #8913
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes