Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

n-api,test: make methods static #20243

Closed
wants to merge 1 commit into from
Closed

n-api,test: make methods static #20243

wants to merge 1 commit into from

Conversation

gabrielschulhof
Copy link
Contributor

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Apr 24, 2018
@gabrielschulhof gabrielschulhof added test Issues and PRs related to the tests. node-api Issues and PRs related to the Node-API. labels Apr 24, 2018
@gabrielschulhof gabrielschulhof added dont-land-on-v4.x and removed tools Issues and PRs related to the tools directory. labels Apr 24, 2018
@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 25, 2018
@gabrielschulhof
Copy link
Contributor Author

Landed in b699264.

gabrielschulhof pushed a commit that referenced this pull request Apr 25, 2018
n-api,test: make methods static
b699264 
PR-URL: #20243
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@gabrielschulhof gabrielschulhof deleted the n-api-make-static branch April 25, 2018 14:53
MylesBorins pushed a commit that referenced this pull request May 4, 2018
@MylesBorins
n-api,test: make methods static
b239591 
PR-URL: #20243
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@MylesBorins MylesBorins mentioned this pull request May 8, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trivikr trivikr trivikr approved these changes

@cjihrig cjihrig cjihrig approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. node-api Issues and PRs related to the Node-API. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@gabrielschulhof @cjihrig @trivikr @BridgeAR @nodejs-github-bot