test: confirm symlink #2014
Closed
test: confirm symlink #2014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trott
added
test
|
lgtm |
|
LGTM |
Trott
added a commit
that referenced
this pull request
Jun 20, 2015
PR-URL: #2014 Reviewed-By: Rod Vagg <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>
|
Merged in b0990ef |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compare
mtimereturned bylstat()to that fromstat(). Former should be mtime of the symlink created by the test, while the latter is the mtime of the file it points to that existed before the test was run.Using
mtimeinstead ofctimebecausectimeis different things on different operating systems and this test will fail on some of them when usingctime.CI: https://jenkins-iojs.nodesource.com/job/iojs+any-pr+multi/53/
This PR addresses a
todocomment in the code.