Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add escapeCodeTimeout as an option to createInterface #19780

Closed
wants to merge 6 commits into from
Closed

add escapeCodeTimeout as an option to createInterface #19780

wants to merge 6 commits into from
+66 −2

Commits on Oct 16, 2018

  1. export ESCAPE_CODE_TIMEOUT

    @raoofha @refack
    raoofha authored and refack committed Oct 16, 2018
    Configuration menu
    Copy the full SHA
    991174e View commit details
    Browse the repository at this point in the history

  2. lib: add escapeCodeTimeout as an option to createInterface 

    escapeCodeTimeout option in createInterface default to
ESCAPE_CODE_TIMEOUT = 500
when set to a NaN or negative number or a value other than
a number set back to default value
    @refack
    Raoof authored and refack committed Oct 16, 2018
    Configuration menu
    Copy the full SHA
    a58d9db View commit details
    Browse the repository at this point in the history

  3. test: add simple test to ensures escapeCodeTimeout option set correctly

    @refack
    Raoof authored and refack committed Oct 16, 2018
    Configuration menu
    Copy the full SHA
    0586244 View commit details
    Browse the repository at this point in the history

  4. lib: rewrite the same code for escapeCodeTimeout option 

    as suggested by @BridgeAR
    @refack
    Raoof authored and refack committed Oct 16, 2018
    Configuration menu
    Copy the full SHA
    b0b8ba5 View commit details
    Browse the repository at this point in the history

  5. lib: rewrite the same code again :)

    @refack
    Raoof authored and refack committed Oct 16, 2018
    Configuration menu
    Copy the full SHA
    fb1ce38 View commit details
    Browse the repository at this point in the history

  6. lib: rewrite the same code for the third time

    @refack
    Raoof authored and refack committed Oct 16, 2018
    Configuration menu
    Copy the full SHA
    5a25fd5 View commit details
    Browse the repository at this point in the history