test: tmpdir creation failures should fail tests #1976
Conversation
|
yes yes, lgtm |
|
Great! Unless someone else swoops in with an objection, I'll merge this Tuesday morning PDT (Tuesday afternoon UTC). |
|
LGTM |
|
Can somebody kick this off in Jenkins? (It's sitting in https://github.com/Trott/io.js master branch if you want to use that.) I appear to have lost my Job/Build permission and can't do it anymore. (/cc @rvagg) |
|
Maybe @Fishrock123 or @chrisdickinson can kick off a CI run for me on this? I seem to have had my CI privs revoked or something... |
|
CI here: https://jenkins-iojs.nodesource.com/job/iojs+any-pr+multi/26/ Not sure why you're getting permission issues. I'll have a look. |
|
@Trott can you rebase on latest master? Also, you're saying you are getting issues creating a job from this project? https://jenkins-iojs.nodesource.com/job/iojs+any-pr+multi/ |
tmpdir creation only happens for tests that need it. So failure to refresh the temporary directory should result in a failed test. PR-URL: nodejs#1976 Reviewed-By: Rod Vagg <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]>
tmpdir creation only happens for tests that need it. So failure to refresh the temporary directory should result in a failed test.
|
Rebased as requested. Yes, when I go to https://jenkins-iojs.nodesource.com/job/iojs+any-pr+multi/, I no longer see "Build With Parameters" even though I'm logged in. And if I just go right to eh URL for building, I get the error in the screenshot above. |
|
CI here: https://jenkins-iojs.nodesource.com/job/iojs+any-pr+multi/27/ I'm no Jenkins wizard, but we'll figure the permissions issue out somehow. |
|
Merged in 88c1831 |
|
I suspect this is a case sensitivity issue with Jenkins, try again now @Trott I've added you back in to the permissions matrix lower-case |
|
@rvagg My permissions are back, so that appears to have done it. Thanks! |
tmpdir creation only happens for tests that need it. So failure to
refresh the temporary directory should result in a failed test.
CI: https://jenkins-iojs.nodesource.com/job/iojs+any-pr+multi/843/
/cc @rvagg who suggested it here and @Fishrock123 who suggested it here