build: make lint-ci work properly on Linux make #19746
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
build
rvagg
requested review from
bnoordhuis and
joyeecheung
and removed request for
bnoordhuis
|
and /cc @nodejs/build |
joyeecheung
approved these changes
Apr 2, 2018
I didn't know that we run linters on FreeBSD so yeah, this is probably just a quirk of gmake on FreeBSD. |
rvagg
added a commit
that referenced
this pull request
Apr 3, 2018
PR-URL: #19746 Reviewed-By: Joyee Cheung <[email protected]>
|
Looks like the commit sha is not posted here: c5928ab |
BridgeAR
pushed a commit
to BridgeAR/node
that referenced
this pull request
May 1, 2018
PR-URL: nodejs#19746 Reviewed-By: Joyee Cheung <[email protected]>
|
Backporting this. Let's hope it's not a problem. |
ryzokuken
pushed a commit
to ryzokuken/node
that referenced
this pull request
Jun 11, 2018
PR-URL: nodejs#19746 Reviewed-By: Joyee Cheung <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Jun 14, 2018
PR-URL: #19746 Reviewed-By: Joyee Cheung <[email protected]>
Merged
|
@ryzokuken thanks for the backport on this, would you mind having a go for 6.x too? once we get full coverage of all of the active branches then we can properly implement changes in CI. |
rvagg
added a commit
that referenced
this pull request
Aug 16, 2018
PR-URL: #19746 Reviewed-By: Joyee Cheung <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to ditch the FreeBSD 10 machines from running node-test-lint and just get the jenkins-workspace machines to do it. Unfortunately it doesn't work because it seems we're using a quirk of
gmakethat ships with FreeBSD 10.$(wildcard test/addons/??_*/*.cc test/addons/??_*/*.h)is executed whenMakefileis loaded, and before the body oflint-addon-docsis executed. So in a pristine clone it expands to nothing, since those files are created bytest/addons/.docbuildstampwhich is a direct dependency oflint-addon-docs(it'd probably be OK if that was done before the call to$(MAKE) lint-addon-docsbut thenmake lint-addon-docsas a stand-alone wouldn't work)./cc @bnoordhuis who last tried to touch this stuff when attempting a refactor in d9b59de which was subsequently reverted
/cc @joyeecheung who introduced part of this functionality in #16377 and may have more of a clue than me about why this only seems to work on the FreeBSD 10
linterhosts