fs: fix missing 'error' event in ReadStream/WriteSteam destroy(err) #19735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
fs
mscdex
reviewed
Apr 1, 2018
| @@ -0,0 +1,41 @@ | |||
| // Copyright Joyent, Inc. and other Node contributors. | |||
There was a problem hiding this comment.
IIRC all of this commented text shouldn't be added for new tests.
There was a problem hiding this comment.
Yeah, new source files should never include the copyright boilerplate
There was a problem hiding this comment.
I removed the copyright boilerplate. thanks!
fs.ReadStream / fs.WriteStrem destroy([error]) function should emit 'error' event if [error] is set. Fixes: nodejs#19727
lpinca
approved these changes
Apr 2, 2018
cjihrig
approved these changes
Apr 2, 2018
jasnell
approved these changes
Apr 2, 2018
trivikr
approved these changes
Apr 3, 2018
BridgeAR
approved these changes
Apr 9, 2018
BridgeAR
added
the
author ready
|
Landed in 6e2d5af 🎉 |
BridgeAR
pushed a commit
to BridgeAR/node
that referenced
this pull request
Apr 9, 2018
fs.ReadStream / fs.WriteStream destroy([error]) function should emit 'error' event if `error` is set. PR-URL: nodejs#19735 Fixes: nodejs#19727 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
|
@range3 congratulations on your first commit to Node.js and to officially becoming a contributor! |
targos
pushed a commit
that referenced
this pull request
Apr 12, 2018
fs.ReadStream / fs.WriteStream destroy([error]) function should emit 'error' event if `error` is set. PR-URL: #19735 Fixes: #19727 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fs.ReadStream / fs.WriteStrem destroy([error]) function
should emit 'error' event if [error] is set.
Fixes: #19727
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes