Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test : refactor parallel/test-tls-ca-concat.js #19092

Closed
wants to merge 1 commit into from
Closed

test : refactor parallel/test-tls-ca-concat.js #19092

wants to merge 1 commit into from

Conversation

juggernaut451
Copy link
Contributor

Implementing common.mustCall and changing the function to arrow function

Fixes : #14544

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Mar 2, 2018
@jasnell
Copy link
Member

jasnell commented Mar 5, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/13507/

@juggernaut451
test: refactor parallel/test-tls-ca-concat.js
ee77247 
Implementing common.mustCall and changing the function to arrow function

Fixes : nodejs#14544
@juggernaut451
Copy link
Contributor Author

Resolved :)

@tniessen tniessen added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 14, 2018
@tniessen
Copy link
Member

tniessen commented Mar 14, 2018 •
edited
Loading

New CI: https://ci.nodejs.org/job/node-test-pull-request/13842/
New CI: https://ci.nodejs.org/job/node-test-pull-request/13674/

tniessen pushed a commit that referenced this pull request Mar 24, 2018
@juggernaut451 @tniessen
test: refactor parallel/test-tls-ca-concat.js
ca22c96 
PR-URL: #19092
Fixes: #14544
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@tniessen
Copy link
Member

Landed in ca22c96.

@tniessen tniessen closed this Mar 24, 2018
targos pushed a commit that referenced this pull request Mar 27, 2018
@juggernaut451 @targos
test: refactor parallel/test-tls-ca-concat.js
0310df8 
PR-URL: #19092
Fixes: #14544
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
BethGriggs pushed a commit that referenced this pull request Dec 3, 2018
@juggernaut451 @BethGriggs
test: refactor parallel/test-tls-ca-concat.js
146c488 
PR-URL: #19092
Fixes: #14544
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@BethGriggs BethGriggs mentioned this pull request Dec 4, 2018
Merged
This was referenced Dec 18, 2018
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardlau richardlau richardlau approved these changes

@tniessen tniessen tniessen approved these changes

@cjihrig cjihrig cjihrig approved these changes

@addaleax addaleax addaleax approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@juggernaut451 @jasnell @tniessen @addaleax @cjihrig @richardlau @BethGriggs @nodejs-github-bot