Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: add falsely removed eslint rules #18933

Closed
wants to merge 1 commit into from
Closed

tools: add falsely removed eslint rules #18933

wants to merge 1 commit into from

Conversation

BridgeAR
Copy link
Member

This adds the eslint rules back in that were falsely removed while
landing #18566.

Refs: #18566

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

tools

@BridgeAR
tools: add falsely removed eslint rules
396a79d 
This adds the eslint rules back in that were falsely removed while
landing nodejs#18566.

Refs: nodejs#18566
@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Feb 22, 2018
@BridgeAR BridgeAR added the fast-track PRs that do not need to wait for 48 hours to land. label Feb 22, 2018
mcollina
mcollina approved these changes Feb 22, 2018
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BridgeAR
Copy link
Member Author

Light-CI https://ci.nodejs.org/job/node-test-commit-light/308/

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 22, 2018
@BridgeAR BridgeAR mentioned this pull request Feb 22, 2018
Closed
2 tasks
BridgeAR added a commit to BridgeAR/node that referenced this pull request Feb 22, 2018
@BridgeAR
tools: add falsely removed eslint rules
13637d2 
This adds the eslint rules back in that were falsely removed while
landing nodejs#18566.

PR-URL: nodejs#18933
Refs: nodejs#18566
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@BridgeAR
Copy link
Member Author

Landed in 13637d2

@BridgeAR BridgeAR closed this Feb 22, 2018
@MylesBorins
Copy link
Contributor

should land with #18566

BridgeAR added a commit to BridgeAR/node that referenced this pull request May 1, 2018
@BridgeAR
tools: add falsely removed eslint rules
8de20e0 
This adds the eslint rules back in that were falsely removed while
landing nodejs#18566.

PR-URL: nodejs#18933
Refs: nodejs#18566
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
MayaLekova pushed a commit to MayaLekova/node that referenced this pull request May 8, 2018
@BridgeAR @MayaLekova
tools: add falsely removed eslint rules
b8b25e8 
This adds the eslint rules back in that were falsely removed while
landing nodejs#18566.

PR-URL: nodejs#18933
Refs: nodejs#18566
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@BridgeAR BridgeAR deleted the fix-merge-error branch April 1, 2019 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devsnek devsnek devsnek approved these changes

@cjihrig cjihrig cjihrig approved these changes

@jasnell jasnell jasnell approved these changes

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@BridgeAR @MylesBorins @mcollina @jasnell @cjihrig @devsnek @nodejs-github-bot