test: fix missing param in benchmark-timers #18734
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apapirovski
added
the
fast-track
BridgeAR
approved these changes
Feb 12, 2018
BridgeAR
added
the
author ready
benjamingr
approved these changes
Feb 12, 2018
|
Something seems to be off in the CI, doesn't look related but maybe I missed it |
|
@benjamingr Build infra has been flaky for a while now (rather than just the usual flaky tests)... not really sure what's going on exactly. |
|
It is definitely not related. We just have massive failures on our CI... See #18660 |
|
Landed in a27e443 |
BridgeAR
pushed a commit
to BridgeAR/node
that referenced
this pull request
Feb 12, 2018
PR-URL: nodejs#18734 Fixes: nodejs#18730 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Feb 21, 2018
PR-URL: #18734 Fixes: #18730 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Feb 21, 2018
PR-URL: #18734 Fixes: #18730 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Feb 21, 2018
PR-URL: #18734 Fixes: #18730 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
MayaLekova
pushed a commit
to MayaLekova/node
that referenced
this pull request
May 8, 2018
PR-URL: nodejs#18734 Fixes: nodejs#18730 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Aug 7, 2018
PR-URL: #18734 Fixes: #18730 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
rvagg
pushed a commit
that referenced
this pull request
Aug 16, 2018
PR-URL: #18734 Fixes: #18730 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a new benchmark was added to
timers, the test running these benchmarks was not updated to include the newnparameter.Fixes: #18730
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test