Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

async_hooks: rename PromiseWrap.parentId #18633

Merged
merged 1 commit into from
Feb 12, 2018
Merged

async_hooks: rename PromiseWrap.parentId #18633

merged 1 commit into from
Feb 12, 2018

Commits on Feb 12, 2018

  1. async_hooks: rename PromiseWrap.parentId 

    Rename the `parentId` property on the PromiseWrap object to a
`isChainedPromise` property. The former wasn't quite useful as it was
always defined to be the same value as the trigger id available in the
init hook. Instead rename the property to be closer to the information
it communicates: whether the promise is a chained promise or not.

PR-URL: nodejs#18633
Fixes: nodejs#18470
Reviewed-By: Andreas Madsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Tiancheng "Timothy" Gu <[email protected]>
    @ofrobots
    ofrobots committed Feb 12, 2018
    Configuration menu
    Copy the full SHA
    9f6a565 View commit details
    Browse the repository at this point in the history