tools: add .mjs linting for Windows #18569
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
build
vsemozhetbyt
added
tools
addaleax
approved these changes
Feb 4, 2018
TimothyGu
approved these changes
Feb 4, 2018
apapirovski
approved these changes
Feb 4, 2018
|
It seems we cannot CI-check this (we do not lint on Windows machines), but I've checked the command locally. |
vsemozhetbyt
added a commit
that referenced
this pull request
Feb 4, 2018
PR-URL: #18569 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]>
|
Landed in 9974d6a |
2 tasks
MylesBorins
pushed a commit
that referenced
this pull request
Feb 21, 2018
PR-URL: #18569 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Feb 21, 2018
PR-URL: #18569 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Feb 21, 2018
PR-URL: #18569 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]>
Merged
|
Should this be backported to |
2 tasks
|
Backport: #19496 |
MylesBorins
pushed a commit
that referenced
this pull request
Mar 21, 2018
Backport-PR-URL: #19496 PR-URL: #18569 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Mar 28, 2018
Backport-PR-URL: #19496 PR-URL: #18569 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Mar 30, 2018
Backport-PR-URL: #19496 PR-URL: #18569 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]>
Merged
MayaLekova
pushed a commit
to MayaLekova/node
that referenced
this pull request
May 8, 2018
PR-URL: nodejs#18569 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
tools, modules
Sync Windows linting with
node/Makefile
Line 1104 in 05e702d
This seems to be slipped in c8a389e