Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: fix cctest target with --enable-static #17992

Closed
wants to merge 1 commit into from
Closed

build: fix cctest target with --enable-static #17992

wants to merge 1 commit into from

Commits on Jan 5, 2018

  1. build: fix cctest target with --enable-static 

    Currently the cctest target build will fail if configured with --enable-static

$ ./configure --enable-static
$ make

There're some function multiple definition errors such as:
  out/Release/obj.target/node/src/node_crypto.o: In function `node::crypto::RandomBytesWork(uv_work_s*)':
  node_crypto.cc:(.text+0x60): multiple definition of `node::crypto::RandomBytesWork(uv_work_s*)'
  out/Release/obj.target/node/src/node_crypto.o:node_crypto.cc:(.text+0x60): first defined here

It's caused by repetition objects in libraries and libnode.a.
This CL makes those libraries guarded by 'node_target_type!="static_library"'.
    @liqyan
    liqyan committed Jan 5, 2018
    Configuration menu
    Copy the full SHA
    98a5d31 View commit details
    Browse the repository at this point in the history