test: fix flaky test-http-pipeline-flood #17955
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apapirovski
force-pushed
the
fix-test-http-pipeline-flood
branch
2 times, most recently
from
888a02f
to
a41fba7
Compare
apapirovski
force-pushed
the
fix-test-http-pipeline-flood
branch
from
a41fba7
to
0ea2754
Compare
apapirovski
added
the
author ready
|
ping @nodejs/http @nodejs/http2 — this test fails fairly regularly so it would be nice to get it fixed. The |
jasnell
approved these changes
Jan 5, 2018
|
Landed in b396c4d |
apapirovski
added a commit
that referenced
this pull request
Jan 6, 2018
PR-URL: #17955 Refs: #16317 Reviewed-By: James M Snell <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Jan 8, 2018
PR-URL: #17955 Refs: #16317 Reviewed-By: James M Snell <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Jan 9, 2018
PR-URL: #17955 Refs: #16317 Reviewed-By: James M Snell <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Jan 9, 2018
PR-URL: #17955 Refs: #16317 Reviewed-By: James M Snell <[email protected]>
Merged
TimothyGu
removed
the
author ready
MylesBorins
pushed a commit
that referenced
this pull request
Jan 24, 2018
PR-URL: #17955 Refs: #16317 Reviewed-By: James M Snell <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Jan 24, 2018
PR-URL: #17955 Refs: #16317 Reviewed-By: James M Snell <[email protected]>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Feb 11, 2018
PR-URL: #17955 Refs: #16317 Reviewed-By: James M Snell <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Feb 12, 2018
PR-URL: #17955 Refs: #16317 Reviewed-By: James M Snell <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Feb 13, 2018
PR-URL: #17955 Refs: #16317 Reviewed-By: James M Snell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes one of the issues with this test (the repeated timeout, for which there's no real reason to validate that it only occurs exactly once). Haven't been able to reproduce the other one so perhaps there was a bug that was fixed in the meantime or something. Not sure.
Refs: #16317
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test