Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: spell corrections in http2.md #17911

Closed
wants to merge 2 commits into from
Closed

doc: spell corrections in http2.md #17911

wants to merge 2 commits into from

Conversation

sreepurnajasti
Copy link
Contributor

@sreepurnajasti sreepurnajasti commented Dec 29, 2017 •
edited
Loading

Made changes such as

  1. acknowledgement to acknowledgment
  2. associatd to associated
  3. millseconds to milliseconds
Checklist
Affected core subsystem(s)

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. http2 Issues or PRs related to the http2 subsystem. labels Dec 29, 2017
@Trott
Copy link
Member

Trott commented Dec 29, 2017

FWIW the same acknowledgement spelling error occurs in one place in errors.md, if someone wants to file a quick pull request to fix that too (or add it as a second commit here?).

@sreepurnajasti
Copy link
Contributor Author

sreepurnajasti commented Dec 29, 2017 •
edited
Loading

@Trott I can do that. Should it be as second commit or another pr? Which can be a best option?

@Trott
Copy link
Member

Trott commented Dec 29, 2017

@Trott I can do that. Should it be as second commit or another pr? Which can be a best option?

Either option is fine. I'd prefer a second commit here, but that's just my personal preference.

@sreepurnajasti
Copy link
Contributor Author

@Trott Done. Please review. Thanks

@Trott
Copy link
Member

Trott commented Dec 29, 2017

Change still looks good to me!

Commit messages can be improved to say "correct spelling in http2.md" and "correct spelling in errors.md". Someone can do that while landing, but if you want to save them a few keystrokes and do it now, awesome.

@Trott
Copy link
Member

Trott commented Dec 29, 2017

("fix spelling in ..." would be fine too instead of "correct spelling in ..." -- either one)

@sreepurnajasti
Copy link
Contributor Author

@Trott Done. Thanks!!!

@starkwang starkwang added the fast-track PRs that do not need to wait for 48 hours to land. label Dec 30, 2017
@starkwang
Copy link
Contributor

CI: https://ci.nodejs.org/job/node-test-pull-request-lite/54/

@tniessen
Copy link
Member

+1 to fast-tracking (one other approval required).

@Trott
Copy link
Member

Trott commented Dec 30, 2017

+1 to fast-tracking.

@tniessen
Copy link
Member

Landed in 27470e4, thank you!

@tniessen tniessen closed this Dec 30, 2017
tniessen pushed a commit that referenced this pull request Dec 30, 2017
@sreepurnajasti @tniessen
doc: correct spelling
27470e4 
PR-URL: #17911
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Weijia Wang <[email protected]>
@sreepurnajasti sreepurnajasti deleted the doc-trivial branch December 31, 2017 07:48
jasnell pushed a commit to jasnell/node that referenced this pull request Jan 9, 2018
@sreepurnajasti @jasnell
doc: correct spelling
526cf84 
PR-URL: nodejs#17911
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Weijia Wang <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jan 9, 2018
@sreepurnajasti @MylesBorins
doc: correct spelling
ab17d84 
Backport-PR-URL: #18050
PR-URL: #17911
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Weijia Wang <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Jan 10, 2018
Merged
MylesBorins pushed a commit that referenced this pull request Jan 10, 2018
@sreepurnajasti @MylesBorins
doc: correct spelling
1181ff7 
Backport-PR-URL: #18050
PR-URL: #17911
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Weijia Wang <[email protected]>
@MylesBorins
Copy link
Contributor

This doesn't land cleanly on v8.x, please feel free to manually backport

kjin pushed a commit to kjin/node that referenced this pull request May 1, 2018
@sreepurnajasti @kjin
doc: correct spelling
5fe065b 
Backport-PR-URL: nodejs#18050
PR-URL: nodejs#17911
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Weijia Wang <[email protected]>
MylesBorins pushed a commit that referenced this pull request May 2, 2018
@sreepurnajasti @MylesBorins
doc: correct spelling
0205b3f 
Backport-PR-URL: #18050
Backport-PR-URL: #20456
PR-URL: #17911
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Weijia Wang <[email protected]>
@MylesBorins MylesBorins mentioned this pull request May 2, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gibfahn gibfahn gibfahn approved these changes

@starkwang starkwang starkwang approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@tniessen tniessen tniessen approved these changes

@cjihrig cjihrig cjihrig approved these changes

@lpinca lpinca lpinca approved these changes

@Trott Trott Trott approved these changes

@jasnell jasnell jasnell approved these changes

@danbev danbev danbev approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. http2 Issues or PRs related to the http2 subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.