Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tls: emit errors happening before handshake's finish #1769

Closed
wants to merge 1 commit into from
Closed

tls: emit errors happening before handshake's finish #1769

wants to merge 1 commit into from

Commits on May 22, 2015

  1. tls: emit errors happening before handshake's finish 

    This fixes a race condition introduced in 80342f6.
`socket.destroy(err)` only emits the passed error
when `socket._writableState.errorEmitted === false`,
`ssl.onerror` sets `errorEmitted = true`
just before calling `socket.destroy()`.

See #1119
See #1711
    @skenqbx
    skenqbx committed May 22, 2015
    Configuration menu
    Copy the full SHA
    90ec81a View commit details
    Browse the repository at this point in the history