Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: Update es module loader example to use module.builtinModules #17385

Closed
wants to merge 2 commits into from
Closed

doc: Update es module loader example to use module.builtinModules #17385

wants to merge 2 commits into from

Conversation

guybedford
Copy link
Contributor

This makes the example somewhat less intimidating hopefully.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

esmodules, doc

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Nov 29, 2017
@guybedford guybedford force-pushed the module-doc-builtinModules branch from 9596809 to fbe7afc Compare November 29, 2017 09:23
maclover7
maclover7 approved these changes Nov 29, 2017
View reviewed changes
Copy link
Contributor

@maclover7 maclover7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maclover7
Copy link
Contributor

CI: https://ci.nodejs.org/job/node-test-pull-request/11802/

jdalton
jdalton reviewed Nov 30, 2017
View reviewed changes
doc/api/esm.md Outdated
@@ -147,15 +147,13 @@ be written:
import url from 'url';
import path from 'path';
import process from 'process';
import module from 'module';
Copy link
Member

@jdalton jdalton Nov 30, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe capital Module to reduce confusion with the CJS form.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only saw this now for some reason, sounds sensible!

@maclover7 maclover7 added the wip Issues and PRs that are still a work in progress. label Dec 7, 2017
@maclover7 maclover7 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. and removed wip Issues and PRs that are still a work in progress. labels Dec 8, 2017
@maclover7
Copy link
Contributor

CI: https://ci.nodejs.org/job/node-test-pull-request-lite/8/

@apapirovski
Copy link
Contributor

Landed in efc3859

@apapirovski apapirovski closed this Dec 9, 2017
apapirovski pushed a commit that referenced this pull request Dec 9, 2017
@guybedford @apapirovski
doc: esm loader example with module.builtinModules
efc3859 
PR-URL: #17385
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Jon Moss <[email protected]>
Reviewed-By: Timothy Gu <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
@guybedford @MylesBorins
doc: esm loader example with module.builtinModules
f48e6da 
PR-URL: #17385
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Jon Moss <[email protected]>
Reviewed-By: Timothy Gu <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
@guybedford @MylesBorins
doc: esm loader example with module.builtinModules
b015747 
PR-URL: #17385
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Jon Moss <[email protected]>
Reviewed-By: Timothy Gu <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Dec 12, 2017
Merged
@addaleax addaleax removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 13, 2017
gibfahn pushed a commit that referenced this pull request Dec 20, 2017
@guybedford @gibfahn
doc: esm loader example with module.builtinModules
5e12a9c 
PR-URL: #17385
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Jon Moss <[email protected]>
Reviewed-By: Timothy Gu <[email protected]>
@gibfahn gibfahn mentioned this pull request Dec 20, 2017
Closed
gibfahn pushed a commit that referenced this pull request Dec 20, 2017
@guybedford @gibfahn
doc: esm loader example with module.builtinModules
101b0c7 
PR-URL: #17385
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Jon Moss <[email protected]>
Reviewed-By: Timothy Gu <[email protected]>
@gibfahn gibfahn mentioned this pull request Dec 20, 2017
Merged
gibfahn pushed a commit that referenced this pull request Dec 20, 2017
@guybedford @gibfahn
doc: esm loader example with module.builtinModules
f36ba1a 
PR-URL: #17385
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Jon Moss <[email protected]>
Reviewed-By: Timothy Gu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdalton jdalton jdalton left review comments

@maclover7 maclover7 maclover7 approved these changes

@cjihrig cjihrig cjihrig approved these changes

@targos targos targos approved these changes

@TimothyGu TimothyGu TimothyGu approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@guybedford @maclover7 @apapirovski @jdalton @TimothyGu @targos @cjihrig @addaleax @gibfahn @nodejs-github-bot