Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix v8 tests #17383

Merged
merged 2 commits into from
Nov 30, 2017
Merged

Fix v8 tests #17383

merged 2 commits into from
Nov 30, 2017

Commits on Nov 30, 2017

  1. Revert "deps: cherry-pick 3c8195d from V8 upstream" 

    This reverts commit e7f30db.

The original commit included tests for AsyncIterator that broke on 6.2

PR-URL: nodejs#17383
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Yang Guo <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
    @MylesBorins
    MylesBorins committed Nov 30, 2017
    Configuration menu
    Copy the full SHA
    f5ec28d View commit details
    Browse the repository at this point in the history

  2. deps: backport 3c8195d from V8 upstream 

    Original commit message:
    Fix map constructor to correctly throw.

    We need to throw before rethrowing, otherwise the exception does
    not trigger a debugger event and is not reported if uncaught.

    [email protected], [email protected]

    Bug: v8:7047
    Change-Id: I7ce0253883a21d6059e4e0ed0fc56dc55a0dcba6
    Reviewed-on: https://chromium-review.googlesource.com/758372
    Reviewed-by: Jakob Gruber <[email protected]>
    Reviewed-by: Sathya Gunasekaran <[email protected]>
    Commit-Queue: Yang Guo <[email protected]>
    Cr-Commit-Position: refs/heads/master@{nodejs#49237}

Fixes: nodejs#17270
PR-URL: nodejs#17383
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Yang Guo <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
    @MylesBorins
    MylesBorins committed Nov 30, 2017
    Configuration menu
    Copy the full SHA
    58adb3c View commit details
    Browse the repository at this point in the history