Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor async_hooks initTriggerId #17273

Closed
wants to merge 7 commits into from
Closed

Refactor async_hooks initTriggerId #17273

wants to merge 7 commits into from

Commits on Dec 19, 2017

  1. async_hooks: rename initTriggerId 

    rename initTriggerId to defaultTriggerAsyncId such it matches the rest
of our naming.
    @AndreasMadsen
    AndreasMadsen committed Dec 19, 2017
    Configuration menu
    Copy the full SHA
    d4ae984 View commit details
    Browse the repository at this point in the history

  2. async_hooks: separate missing from default context 

    When context is missing the executionAsyncId will be zero. For the
default triggerAsyncId the zero value was used to default to the
executionAsyncId. While this was not technically wrong because the
functions are different themself, it poorly separated the two concepts.
    @AndreasMadsen
    AndreasMadsen committed Dec 19, 2017
    Configuration menu
    Copy the full SHA
    c2cd04b View commit details
    Browse the repository at this point in the history

  3. async_hooks: use scope for defaultTriggerAsyncId 

    Previously the getter would mutate the kDefaultTriggerAsncId value. This
refactor changes the setter to bind the current kDefaultTriggerAsncId to
a scope, such that the getter doesn't have to mutate its own value.
    @AndreasMadsen
    AndreasMadsen committed Dec 19, 2017
    Configuration menu
    Copy the full SHA
    8a50186 View commit details
    Browse the repository at this point in the history

  4. [squash] support opaque parameter

    @AndreasMadsen
    AndreasMadsen committed Dec 19, 2017
    Configuration menu
    Copy the full SHA
    2b3db6e View commit details
    Browse the repository at this point in the history

  5. [squash] move shutdown to outer function

    @AndreasMadsen
    AndreasMadsen committed Dec 19, 2017
    Configuration menu
    Copy the full SHA
    019b365 View commit details
    Browse the repository at this point in the history

  6. [squash] avoid closure in dgram

    @AndreasMadsen
    AndreasMadsen committed Dec 19, 2017
    Configuration menu
    Copy the full SHA
    e67a43d View commit details
    Browse the repository at this point in the history

  7. [squash] use apply instead of destructing

    @AndreasMadsen
    AndreasMadsen committed Dec 19, 2017
    Configuration menu
    Copy the full SHA
    cc45969 View commit details
    Browse the repository at this point in the history