repl: remove unnecessary check for globals #1722
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
|
@cjihrig do you have commit bit? |
|
@indutny yea |
|
@cjihrig may I ask you to land it? ;) |
cjihrig
pushed a commit
that referenced
this pull request
May 17, 2015
There is no need to check for globals and also check if it is an array. PR-URL: #1722 Reviewed-By: Colin Ihrig <[email protected]>
|
Sure. Landed in 5f33521 |
andrewdeandrade
pushed a commit
to andrewdeandrade/node
that referenced
this pull request
Jun 3, 2015
There is no need to check for globals and also check if it is an array. PR-URL: nodejs/node#1722 Reviewed-By: Colin Ihrig <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry for making this at my previous commit, removed the
!globals, thanks @cjihrig/cc @indutny