doc: make stream.Readable consistent #16786
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rest of the document uses `stream.Readable` or `stream.Writable`. This patch makes the usage consistent in the parameter description.
thefourtheye
added
doc
nodejs-github-bot
added
doc
lpinca
approved these changes
Nov 6, 2017
gireeshpunathil
approved these changes
Nov 6, 2017
joyeecheung
approved these changes
Nov 6, 2017
jasnell
approved these changes
Nov 6, 2017
jasnell
pushed a commit
that referenced
this pull request
Nov 6, 2017
Rest of the document uses `stream.Readable` or `stream.Writable`. This patch makes the usage consistent in the parameter description. PR-URL: #16786 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: James M Snell <[email protected]>
|
Landed in 8eef52e |
cjihrig
pushed a commit
to cjihrig/node
that referenced
this pull request
Nov 6, 2017
Rest of the document uses `stream.Readable` or `stream.Writable`. This patch makes the usage consistent in the parameter description. PR-URL: nodejs#16786 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Nov 14, 2017
Rest of the document uses `stream.Readable` or `stream.Writable`. This patch makes the usage consistent in the parameter description. PR-URL: #16786 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
gibfahn
pushed a commit
that referenced
this pull request
Dec 19, 2017
Rest of the document uses `stream.Readable` or `stream.Writable`. This patch makes the usage consistent in the parameter description. PR-URL: #16786 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: James M Snell <[email protected]>
Closed
gibfahn
pushed a commit
that referenced
this pull request
Dec 20, 2017
Rest of the document uses `stream.Readable` or `stream.Writable`. This patch makes the usage consistent in the parameter description. PR-URL: #16786 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rest of the document uses
stream.Readableorstream.Writable. Thispatch makes the usage consistent in the parameter description.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
doc stream