Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: update fixturesDir to fixtures.readKey in test-https-agent-servername.js #16016

Closed
wants to merge 1 commit into from
Closed

test: update fixturesDir to fixtures.readKey in test-https-agent-servername.js #16016

wants to merge 1 commit into from

Conversation

bnb
Copy link
Contributor

@bnb bnb commented Oct 6, 2017 •
edited by refack
Loading

Update usage of fixturesDir to fixtures.readKey in test-https-agent-servername.js

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Oct 6, 2017
@bnb bnb changed the title doc: update fixturesDir to fixtures.readKey in test-https-agent-servername.js test: update fixturesDir to fixtures.readKey in test-https-agent-servername.js Oct 6, 2017
@mscdex mscdex added the https Issues or PRs related to the https subsystem. label Oct 6, 2017
BridgeAR
BridgeAR approved these changes Oct 6, 2017
View reviewed changes
Copy link
Member

@BridgeAR BridgeAR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but the subsystem in the commit is wrong and has to be fixed while landing. The commit message itself also has to be fixed (shortened).

@Trott Trott added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Oct 7, 2017
@refack
Copy link
Contributor

refack commented Oct 7, 2017 •
edited
Loading

Welcome to the dark side @bnb 😈
Thank you for the contribution, and hope to see more in the future.

Quick CI:
https://ci.nodejs.org/job/node-test-commit-linuxone/9094/ ✔️
https://ci.nodejs.org/job/node-test-linter/12316/ ✔️

@refack refack self-assigned this Oct 7, 2017
@refack refack mentioned this pull request Oct 7, 2017
Closed
@refack
Copy link
Contributor

refack commented Oct 7, 2017

Landed in d56f03c

@bnb congrats 🍾

@refack refack closed this Oct 7, 2017
refack pushed a commit that referenced this pull request Oct 7, 2017
@bnb @refack
test: update fixturesDir to fixtures.readKey
d56f03c 
PR-URL: #16016
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
MylesBorins pushed a commit that referenced this pull request Oct 11, 2017
@bnb @MylesBorins
test: update fixturesDir to fixtures.readKey
8ea9648 
PR-URL: #16016
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Oct 11, 2017
Merged
addaleax pushed a commit to addaleax/ayo that referenced this pull request Oct 12, 2017
@bnb @addaleax
test: update fixturesDir to fixtures.readKey
a339372 
PR-URL: nodejs/node#16016
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
MylesBorins pushed a commit that referenced this pull request Nov 14, 2017
@bnb @MylesBorins
test: update fixturesDir to fixtures.readKey
f67c038 
PR-URL: #16016
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Nov 21, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Nov 21, 2017
@bnb @MylesBorins
test: update fixturesDir to fixtures.readKey
2e039d2 
PR-URL: #16016
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
MylesBorins pushed a commit that referenced this pull request Nov 28, 2017
@bnb @MylesBorins
test: update fixturesDir to fixtures.readKey
107acb1 
PR-URL: #16016
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
@refack refack removed their assignment Oct 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BridgeAR BridgeAR BridgeAR approved these changes

@richardlau richardlau richardlau approved these changes

@tniessen tniessen tniessen approved these changes

@cjihrig cjihrig cjihrig approved these changes

@benjamingr benjamingr benjamingr approved these changes

@refack refack refack approved these changes

Assignees
No one assigned
Labels
code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. https Issues or PRs related to the https subsystem. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.