Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: increase fs.exists coverage #15963

Closed
wants to merge 1 commit into from
Closed

test: increase fs.exists coverage #15963

wants to merge 1 commit into from

Conversation

NigelKibodeaux
Copy link
Contributor

Tests the case of calling fs.exists without a callback.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Oct 6, 2017
@mscdex mscdex added the fs Issues and PRs related to the fs subsystem / file system. label Oct 6, 2017
@Trott Trott added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Oct 6, 2017
cjihrig
cjihrig reviewed Oct 7, 2017
View reviewed changes
test/parallel/test-fs-exists.js Outdated
@@ -30,6 +30,8 @@ fs.exists(f, common.mustCall(function(y) {
assert.strictEqual(y, true);
}));

fs.exists(f);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably assert something.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For instance,

assert.doesNotThrow(() => fs.exists(f));

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I just fixed it.

cjihrig
cjihrig reviewed Oct 10, 2017
View reviewed changes
test/parallel/test-fs-exists.js Outdated
@@ -30,6 +30,8 @@ fs.exists(f, common.mustCall(function(y) {
assert.strictEqual(y, true);
}));

assert.doesNotThrow(fs.exists(f));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't quite right yet. In this case, fs.exists(f) will be evaluated, and the return value will be passed to assert.doesNotThrow(). If you wrap fs.exists(f) in a function first, then it will be good to go. It would look like:

assert.doesNotThrow(() => { fs.exists(f); });

@BridgeAR
Copy link
Member

Ping @NigelKibodeaux

@gireeshpunathil
Copy link
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/10842/
and ping @jasnell @cjihrig

mhdawson
mhdawson approved these changes Oct 19, 2017
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mhdawson
Copy link
Member

CI failed with merge conflict. My guess it because of the different commeints. @NigelKibodeaux could you squash the commits down to 1 ?

@apapirovski
Copy link
Member

Hi @NigelKibodeaux, would you still like to follow up on this so that it can land in Node? Let me know if I can offer any pointers. Thanks for helping improve Node!

@NigelKibodeaux
Copy link
Contributor Author

Hi @apapirovski, I'm attempting to squash my commits. I hope this works...

@apapirovski
Copy link
Member

apapirovski commented Oct 25, 2017 •
edited
Loading

@NigelKibodeaux seems to have worked 😄 I'll get a CI started and post a link shortly.

Edit: oops, can you remove the merge commit. Let me know if you need pointers.

@tniessen
Copy link
Member

tniessen commented Oct 28, 2017 •
edited
Loading

I rebased and pushed for you 😃 CI: https://ci.nodejs.org/job/node-test-commit/13558/

(For further reference, NigelKibodeaux@6d9abdd is the original commit.)

tniessen pushed a commit that referenced this pull request Oct 28, 2017
@NigelKibodeaux @tniessen
test: increase fs.exists coverage
4ed152e 
PR-URL: #15963
Reviewed-By: Anatoli Papirovski <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
@tniessen
Copy link
Member

Landed in 4ed152e, thank you! 🎉

@tniessen tniessen closed this Oct 28, 2017
@NigelKibodeaux
Copy link
Contributor Author

NigelKibodeaux commented Oct 28, 2017 via email

@jasnell jasnell mentioned this pull request Oct 30, 2017
Merged
gibfahn pushed a commit that referenced this pull request Oct 30, 2017
@NigelKibodeaux @gibfahn
test: increase fs.exists coverage
1cfb1b2 
PR-URL: #15963
Reviewed-By: Anatoli Papirovski <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
gibfahn pushed a commit that referenced this pull request Oct 30, 2017
@NigelKibodeaux @gibfahn
test: increase fs.exists coverage
2143cff 
PR-URL: #15963
Reviewed-By: Anatoli Papirovski <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
gibfahn pushed a commit that referenced this pull request Oct 31, 2017
@NigelKibodeaux @gibfahn
test: increase fs.exists coverage
4f47e2d 
PR-URL: #15963
Reviewed-By: Anatoli Papirovski <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
@gibfahn gibfahn mentioned this pull request Oct 31, 2017
Merged
Qard pushed a commit to ayojs/ayo that referenced this pull request Nov 2, 2017
@NigelKibodeaux @Qard
test: increase fs.exists coverage
212ef30 
PR-URL: nodejs/node#15963
Reviewed-By: Anatoli Papirovski <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Qard pushed a commit to ayojs/ayo that referenced this pull request Nov 2, 2017
@NigelKibodeaux @Qard
test: increase fs.exists coverage
5ceadf0 
PR-URL: nodejs/node#15963
Reviewed-By: Anatoli Papirovski <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
MylesBorins pushed a commit that referenced this pull request Nov 16, 2017
@NigelKibodeaux @MylesBorins
test: increase fs.exists coverage
dce1c09 
PR-URL: #15963
Reviewed-By: Anatoli Papirovski <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Nov 21, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Nov 21, 2017
@NigelKibodeaux @MylesBorins
test: increase fs.exists coverage
603f2f7 
PR-URL: #15963
Reviewed-By: Anatoli Papirovski <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
MylesBorins pushed a commit that referenced this pull request Nov 28, 2017
@NigelKibodeaux @MylesBorins
test: increase fs.exists coverage
cb1d16d 
PR-URL: #15963
Reviewed-By: Anatoli Papirovski <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
addaleax pushed a commit to ayojs/ayo that referenced this pull request Dec 7, 2017
@NigelKibodeaux @addaleax
test: increase fs.exists coverage
75c6d54 
PR-URL: nodejs/node#15963
Reviewed-By: Anatoli Papirovski <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell left review comments

@mhdawson mhdawson mhdawson approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@cjihrig cjihrig cjihrig approved these changes

@apapirovski apapirovski apapirovski approved these changes

Assignees
No one assigned
Labels
code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. fs Issues and PRs related to the fs subsystem / file system. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.