[v6.x backport] repl: refactor LineParser implementation
#15773
Conversation
Move the core logic from `LineParser` should fail handling into the recoverable error check for the REPL default eval. PR-URL: #6171 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
|
This supercedes the PR submitted earlier. |
|
Lots of |
MylesBorins
force-pushed
the
v6.x-staging
branch
from
355249a
to
0597d3f
Compare
|
@lance the original PR was Semver-Major, how has this changed to make it Semver-Patch? |
|
@MylesBorins to be honest, I'm not sure how it should be handled. My initial reasoning for doing the backport is that it fixes #15704, which is an issue in 6.x. If I'm reading git history/blame correctly (and I may not be), editor mode support landed in master after the line parser refactor implementation. However, when editor mode was backported to v6.x the So, I honestly don't know what the answer is. But it seems like this would be the most straightforward way to implement the fix. I initially began a PR that just pulled some relevant bits from the I'm ok with either approach, and would be happy to close this and reopen the former if that makes more sense. |
|
/cc @nodejs/lts to chime in If we can land this as semver patch we can get it in the next release cycle, so no rush |
Assuming I'm understanding this correctly, this is a fix for #15704, in which case I'd be fine with landing it. If it's not urgent there's no reason not to wait till next release though. @lance so to your knowledge this change itself isn't |
|
@gibfahn it doesn't appear to be But to be clear, yes, this is a fix for #15704. |
MylesBorins
force-pushed
the
v6.x-staging
branch
from
54286db
to
3e96c85
Compare
|
CI2: https://ci.nodejs.org/job/node-test-pull-request/10972/ Update new CI looks ok in spite of some unrelated raspberry pi test failures. |
MylesBorins
force-pushed
the
v6.x-staging
branch
from
9219283
to
b0fadbe
Compare
|
Hmm - CI failed badly. Odd. Trying again: https://ci.nodejs.org/job/node-test-pull-request/11119/ Update: An unrelated Windows failure, and a couple of the regular raspberry pi failures. |
|
@nodejs/lts I've landed this in 6ca3640 |
|
@jasnell @Fishrock123 you two originally labelled this change semver major. do you stand by that original review? should I back this out? |
Move the core logic from `LineParser` should fail handling into the recoverable error check for the REPL default eval. Fixes: #15704 Backport-PR-URL: #15773 PR-URL: #6171 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
|
Hey @lance I had to back this out of v6.x as it is breaking coffeescript 😢 |
|
@MylesBorins ok - what's next? I'd like to find a fix for #15704 but I guess this won't be it. |
|
@lance if we can find a way to do this that doesn't break ecosystem modules we can land it |
|
@MylesBorins is there a known way to reproduce the errors that were seen with coffeescript? |
|
Simply running the test suite can reproduce the error
…On Nov 27, 2017 11:44 PM, "Lance Ball" ***@***.***> wrote:
@MylesBorins <https://github.com/mylesborins> is there a known way to
reproduce the errors that were seen with coffeescript?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#15773 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAecV_L-ypZu4Bp5Na0yovVAlUAiM5q9ks5s6srBgaJpZM4PuBPI>
.
|
MylesBorins
force-pushed
the
v6.x-staging
branch
from
88b6795
to
3c4bb3c
Compare
|
How shall we continue here? |
|
@BridgeAR I'm sorry I have been quite consumed with Red Hat related work lately and have not had an opportunity to get back to this. As mentioned in the initial comment, it is meant to address #15704. I do not have a good sense of how important this issue is and whether a backport is really necessary. If so, I assume we'd want it before active LTS ends in April? |
|
I personally would say it is not as important but I do not have a strong opinion in this case. @MylesBorins what do you think? |
|
As the error only exists in the repl and I have not seen other people report the issue, I think it is reasonable to close this if @lance doesn't have time to dig in |
|
OK - I will close this for now. If I get a little breathing room to pick it up again I may. |
Backporting this PR to address #15704. In addition to the basic backport, I have added a test
test/parallel/test-repl-multi-line-templates.jsto test for the issue noted in the issue above.Original pull request: #6171
Original commit message:
Move the core logic from
LineParsershould fail handling into therecoverable error check for the REPL default eval.
PR-URL: #6171
Reviewed-By: James M Snell [email protected]
Reviewed-By: Michaël Zasso [email protected]
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
repl