inspector: not pass zero as task_id #15740
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Inspector doesn't support zero as task_id. Node.js uses 0 at least as microTasksTickObject async_id in next_tick.js. We can ignore this task and not report it to asyncTask* API. Fixes: #15464
nodejs-github-bot
added
c++
|
I've CL for inspector inside V8 as well: https://chromium-review.googlesource.com/c/v8/v8/+/695808 |
|
I'm actually not sure about good fix here and need help from someone experienced in async_hooks. I'm not sure what zero means. If it's not important to include this task into async stack in DevTools then we can just ignore it, if it's important we can report async_task_id + 1 to inspector. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspector doesn't support zero as task_id. Node.js uses 0 at least
as microTasksTickObject async_id in next_tick.js.
We can ignore this task and not report it to asyncTask* API.
Fixes: #15464
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
inspector