-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: adjust Makefile/test-ci, add to vcbuild.bat #1530
Conversation
changed the windows build cmd on the current set up to just |
Missing Also, I'm not super keen about having jslint/cclint as part of the test suite -- it should rather be another step. That's probably for another PR/issue though since this is consistent with the |
tbh I'm trying to be relatively minimal here, it's also missing test-addon which really needs to go in but afaik it's still broken in this configuration - I just need to get something basic going and we can iterate from there. @jbergstroem if you can see a path forward from here to enhance then perhaps lgtm this PR and put in another to take it up a notch, right now I just want to get the basics sorted. |
The patch improves our current situation, so LGTM. |
PR-URL: nodejs#1530 Reviewed-By: Johan Bergström <[email protected]>
PR-URL: nodejs#1530 Reviewed-By: Johan Bergström <[email protected]>
PR-URL: nodejs#1530 PORT-PR-URL: nodejs#1560 PORT-FROM: v2.x / 5472139 Reviewed-By: Johan Bergström <[email protected]>
@@ -112,7 +112,9 @@ test-all-valgrind: test-build | |||
$(PYTHON) tools/test.py --mode=debug,release --valgrind | |||
|
|||
test-ci: | |||
$(PYTHON) tools/test.py -p tap --logfile test.tap -J parallel sequential message |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test
make
test-ci
consistent withtest
and introduce it to vcbuild.bat -- jenkins is now looking for it so the builds are failing without this addition (I've been testing tap output). Also puts in linting to CI which has been missing until now.