url: drop auth in url.resolve() if host changes
#1480
Conversation
Fishrock123
added
the
url
I don't think it should copy over. However, to change that would be > var parsed = url.parse('mailto:[email protected]');
undefined
> parsed.host = 'example.com';
'example.com'
> url.format(parsed);
'mailto:[email protected]' |
|
perhaps @domenic would be interested in reviewing? |
|
What do browsers do? What does the spec (perhaps best tested via https://github.com/jsdom/whatwg-url) do? |
|
I agree with @domenic. Our url module should align with the spec. |
|
Looks like this was never resolved. There's really no question that the user id and password should not be getting copied over.. |
|
@nodejs/http |
|
I concur with @jasnell and this PR |
jasnell
added
the
semver-major
|
@nodejs/ctc ... amazingly, this PR was opened a year ago and still applies cleanly (albeit using a three way merge). It even passes linting! The change LGTM. marked it semver-major because it changes the behavior of url.resolve to drop the auth but it could also be classified as a bug fix. PTAL |
|
CI is green! |
|
@mscdex @cjihrig @trevnorris ... can one of you give this a quick glance over? |
| 'http://diff:[email protected]/'] | ||
| 'http://diff:[email protected]/'], | ||
|
|
||
| // https://github.com/iojs/io.js/issues/1435 |
There was a problem hiding this comment.
This should be changed to point to the nodejs/node repo
There was a problem hiding this comment.
Yep, I was going to change that upon landing (although, I kinda like that it still points to iojs, lol)
|
LGTM |
Fixes: #1435 PR-URL: #1480 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Brian White <[email protected]>
|
It only took 1 year and 5 days but this landed in eb4201f ;-) |
Fixes: #1435 PR-URL: #1480 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Brian White <[email protected]>
#1435
Not sure how to handle this though.