Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps,profiler: parse Windows' "%p" in processor #14510

Closed
wants to merge 2 commits into from
Closed

deps,profiler: parse Windows' "%p" in processor #14510

wants to merge 2 commits into from

Commits on Jul 25, 2017

  1. deps,profiler: parse Windows' "%p" in processor 

    Running the profiler processor (--prof-process) with a profiler
output file generated on Windows (with --prof) results in "UNKNOWN"
code dominating the statistics. This is caused by the processor not
correctly parsing the output of the "%p" format specifier on Windows,
which prints 8 (in 32 bits) or 16 (in 64 bits) hexadecimal characters
without the "0x" prefix. The profiler processor expects a format that
is recognized by parseInt.

This commit creates a thin layer on top of parseInt to parse the
Windows "%p" format for memory addresses correctly.

Fixes: nodejs#8221
Refs:
v8/v8@9041833#diff-738e87867268a7b9c90329adc160855cR167
    @jaimecbernardo
    jaimecbernardo committed Jul 25, 2017
    Configuration menu
    Copy the full SHA
    167ffce View commit details
    Browse the repository at this point in the history

Commits on Jul 27, 2017

  1. fixup: add spaces to conform to JS style

    @jaimecbernardo
    jaimecbernardo committed Jul 27, 2017
    Configuration menu
    Copy the full SHA
    ffc33fb View commit details
    Browse the repository at this point in the history