Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: replace string concatenation with template string literals in test-fs-watchfile.js #14287

Closed
wants to merge 3 commits into from
Closed

test: replace string concatenation with template string literals in test-fs-watchfile.js #14287

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4d76c6b
test:replace string concatenation with template literals in test-fs-w…
Helianthus21 Jul 16, 2017
2ec6bf4
test: remove the last quote
Helianthus21 Jul 16, 2017
ccdc806
test: use path.join to replace path string concatenation
Helianthus21 Jul 18, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion test/parallel/test-fs-watchfile.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ fs.watchFile(enoentFile, {interval: 0}, common.mustCall(function(curr, prev) {
// Watch events should callback with a filename on supported systems.
// Omitting AIX. It works but not reliably.
if (common.isLinux || common.isOSX || common.isWindows) {
const dir = common.tmpDir + '/watch';
const dir = `${common.tmpDir}/watch`;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is Ok.
But it would be much better to use path.join instead, see #14272 (comment)


fs.mkdir(dir, common.mustCall(function(err) {
if (err) assert.fail(err);
Expand Down