docs: Supplement docs for Writable and Transform streams #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Slightly fix and supplement the documentation for Writable#write and Transform#transform methods. Make it more consistent. Mention passing 'buffer' as an encoding param in case chunk is a Buffer.
|
nodejs/node-v0.x-archive#8769 - the same changes for joyent/node |
|
I'm down with this, LGTM so I'll merge, thanks @wizardzloy and sorry for the delay |
|
nope, too far removed from the v1.x branch so it's too messy to pull this in. @wizardzloy could you please either rebase against the io.js/v1.x branch or re-submit these changes again from scratch? |
piscisaureus
pushed a commit
that referenced
this pull request
Jan 12, 2015
Slightly fix and supplement the documentation for Writable#write and Transform#transform methods. Make it more consistent. Mention passing 'buffer' as an encoding param in case chunk is a Buffer. PR: #142 Reviewed-by: Bert Belder <[email protected]> Reviewed-by: Rod Vagg <[email protected]>
|
lgtm & thanks. 68a2d8f |
|
@piscisaureus how did you merge this? my git-fu is lacking and I couldn't get this to work cleanly enough to do quickly. |
boingoing
added a commit
to boingoing/node
that referenced
this pull request
Apr 6, 2017
napi: Remove napi_set_function_name since not all engines can rename functions
This was referenced Jan 31, 2020
This was referenced Feb 11, 2024
This was referenced Feb 11, 2024
eti-p-doray
pushed a commit
to eti-p-doray/node
that referenced
this pull request
May 28, 2024
Merging based on marja@ request.
syg
pushed a commit
to syg/node
that referenced
this pull request
Jun 20, 2024
Merging based on marja@ request.
eti-p-doray
pushed a commit
to eti-p-doray/node
that referenced
this pull request
Aug 28, 2024
Merging based on marja@ request.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Slightly fix and supplement the documentation for Writable#write and
Transform#transform methods. Make it more consistent. Mention
passing 'buffer' as an encoding param in case chunk is a Buffer.