Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cctest: Fix cctest failure on windows #14111

Closed
wants to merge 1 commit into from
+1 −1
Closed

cctest: Fix cctest failure on windows #14111

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
cctest: Fix cctest failure on windows 
Linux converts the ipv6 address "::" to "::1", while windows does not.
By explicitly using "::1" in the test we allow it to succeed on windows.
@MSLaguana
MSLaguana authored Jul 6, 2017

Verified

This commit was signed with the committer’s verified signature.
sandhose Quentin Gliech
GPG key ID: 22D62B84552719FC
Verified
Learn about vigilant mode
commit a2be5d121708e553bbd3f0ffe39ee078c8fdc1cc
2 changes: 1 addition & 1 deletion test/cctest/test_inspector_socket_server.cc
View file
Original file line number Diff line number Diff line change
@@ -621,7 +621,7 @@ TEST_F(InspectorSocketServerTest, BindsToIpV6) {
ASSERT_TRUE(server->Start());

SocketWrapper socket1(&loop);
socket1.Connect("::", server.port(), true);
socket1.Connect("::1", server.port(), true);
socket1.Write(WsHandshakeRequest(MAIN_TARGET_ID));
socket1.Expect(WS_HANDSHAKE_RESPONSE);
server->Stop(ServerHolder::CloseCallback);