Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v8.x backport] lib: fix typos #14044

Closed
wants to merge 1 commit into from
Closed

[v8.x backport] lib: fix typos #14044

wants to merge 1 commit into from

Conversation

BridgeAR
Copy link
Member

@BridgeAR BridgeAR commented Jul 2, 2017

Backport #13741 to 8.x

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

lib

@BridgeAR
lib: fix typos
e02be07 
PR-URL: nodejs#13741
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Roman Reiss <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
@nodejs-github-bot nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. v8.x labels Jul 2, 2017
Trott
Trott approved these changes Jul 3, 2017
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tniessen tniessen changed the title lib: fix typos [v6.x backport] lib: fix typos Jul 3, 2017
@tniessen tniessen changed the title [v6.x backport] lib: fix typos [v8.x backport] lib: fix typos Jul 3, 2017
@addaleax
Copy link
Member

addaleax commented Jul 3, 2017

CI: https://ci.nodejs.org/job/node-test-commit/10927/

addaleax pushed a commit that referenced this pull request Jul 3, 2017
@BridgeAR @addaleax
lib: fix typos
95ab616 
Original-PR-URL: #13741
Original-Reviewed-By: Colin Ihrig <[email protected]>
Original-Reviewed-By: Roman Reiss <[email protected]>
Original-Reviewed-By: James M Snell <[email protected]>
Original-Reviewed-By: Luigi Pinca <[email protected]>
Original-Reviewed-By: Gibson Fahnestock <[email protected]>

PR-URL: #14044
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@addaleax
Copy link
Member

addaleax commented Jul 3, 2017

Landed in v8.x-staging @ 95ab616

@addaleax addaleax closed this Jul 3, 2017
@addaleax addaleax mentioned this pull request Jul 3, 2017
Merged
addaleax pushed a commit that referenced this pull request Jul 11, 2017
@BridgeAR @addaleax
lib: fix typos
8a467ae 
Original-PR-URL: #13741
Original-Reviewed-By: Colin Ihrig <[email protected]>
Original-Reviewed-By: Roman Reiss <[email protected]>
Original-Reviewed-By: James M Snell <[email protected]>
Original-Reviewed-By: Luigi Pinca <[email protected]>
Original-Reviewed-By: Gibson Fahnestock <[email protected]>

PR-URL: #14044
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
addaleax pushed a commit that referenced this pull request Jul 18, 2017
@BridgeAR @addaleax
lib: fix typos
4bb1a3a 
Original-PR-URL: #13741
Original-Reviewed-By: Colin Ihrig <[email protected]>
Original-Reviewed-By: Roman Reiss <[email protected]>
Original-Reviewed-By: James M Snell <[email protected]>
Original-Reviewed-By: Luigi Pinca <[email protected]>
Original-Reviewed-By: Gibson Fahnestock <[email protected]>

PR-URL: #14044
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins pushed a commit that referenced this pull request Aug 14, 2017
@BridgeAR @MylesBorins
lib: fix typos
d133e33 
Original-PR-URL: #13741
Original-Reviewed-By: Colin Ihrig <[email protected]>
Original-Reviewed-By: Roman Reiss <[email protected]>
Original-Reviewed-By: James M Snell <[email protected]>
Original-Reviewed-By: Luigi Pinca <[email protected]>
Original-Reviewed-By: Gibson Fahnestock <[email protected]>

PR-URL: #14044
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins pushed a commit that referenced this pull request Aug 15, 2017
@BridgeAR @MylesBorins
lib: fix typos
600d009 
Original-PR-URL: #13741
Original-Reviewed-By: Colin Ihrig <[email protected]>
Original-Reviewed-By: Roman Reiss <[email protected]>
Original-Reviewed-By: James M Snell <[email protected]>
Original-Reviewed-By: Luigi Pinca <[email protected]>
Original-Reviewed-By: Gibson Fahnestock <[email protected]>

PR-URL: #14044
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins pushed a commit that referenced this pull request Aug 16, 2017
@BridgeAR @MylesBorins
lib: fix typos
81edf59 
Original-PR-URL: #13741
Original-Reviewed-By: Colin Ihrig <[email protected]>
Original-Reviewed-By: Roman Reiss <[email protected]>
Original-Reviewed-By: James M Snell <[email protected]>
Original-Reviewed-By: Luigi Pinca <[email protected]>
Original-Reviewed-By: Gibson Fahnestock <[email protected]>

PR-URL: #14044
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Aug 16, 2017
Merged
This was referenced Sep 5, 2017
Closed
Closed
Closed
Closed
Closed
@BridgeAR BridgeAR deleted the backport-13741-to-8.x branch April 1, 2019 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

@lpinca lpinca lpinca approved these changes

@Trott Trott Trott approved these changes

Assignees
No one assigned
Labels
lib / src Issues and PRs related to general changes in the lib or src directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@BridgeAR @addaleax @Trott @lpinca @cjihrig @MylesBorins @nodejs-github-bot