Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: skip test-fs-readdir-ucs2 if no support #14029

Closed
wants to merge 1 commit into from
Closed

test: skip test-fs-readdir-ucs2 if no support #14029

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Jul 1, 2017

If the filesystem does not support UCS2, do not run the test.

Fixes: #14028

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test fs

@Trott Trott added the wip Issues and PRs that are still a work in progress. label Jul 1, 2017
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Jul 1, 2017
@Trott
Copy link
Member Author

Trott commented Jul 1, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/8919/

@Trott
Copy link
Member Author

Trott commented Jul 1, 2017

Looks like it's working now. Removing the in progress label.

@Trott Trott removed the wip Issues and PRs that are still a work in progress. label Jul 1, 2017
@Trott Trott mentioned this pull request Jul 1, 2017
Closed
richardlau
richardlau reviewed Jul 1, 2017
View reviewed changes
test/parallel/test-fs-readdir-ucs2.js Outdated
try {
fs.closeSync(fs.openSync(fullpath, 'w+'));
} catch (e) {
if (e.message.startsWith('EINVAL')) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is e.code set? If so it might be better to test against it rather than the message.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed. Will change.

@Trott
Copy link
Member Author

Trott commented Jul 1, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/8921/

@Trott Trott mentioned this pull request Jul 2, 2017
Closed
3 tasks
@Trott
test: skip test-fs-readdir-ucs2 if no support
f03541e 
If the filesystem does not support UCS2, do not run the test.

Fixes: nodejs#14028
@Trott
Copy link
Member Author

Trott commented Jul 3, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/8966/

refack pushed a commit to refack/node that referenced this pull request Jul 4, 2017
@Trott @refack
test: skip test-fs-readdir-ucs2 if no support
4dd7d09 
If the filesystem does not support UCS2, do not run the test.

PR-URL: nodejs#14029
Fixes: nodejs#14028
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
@refack refack self-assigned this Jul 4, 2017
@refack
Copy link
Contributor

refack commented Jul 4, 2017 •
edited
Loading

Landed in 4dd7d09
(I don't usually do cradle-robbing, but the red/yellow was bothering me on this fine 4th-of-July morning 🦅 💚 )

Extra CI for sanity of master: https://ci.nodejs.org/job/node-test-commit/10945/

@refack refack closed this Jul 4, 2017
@refack
Copy link
Contributor

refack commented Jul 4, 2017

GGGGGGRRRRRRRRRRRR npm
https://ci.nodejs.org/job/node-test-binary-arm/9040/RUN_SUBSET=3,label=pi3-raspbian-jessie/

addaleax pushed a commit that referenced this pull request Jul 11, 2017
@Trott @addaleax
test: skip test-fs-readdir-ucs2 if no support
5f45165 
If the filesystem does not support UCS2, do not run the test.

PR-URL: #14029
Fixes: #14028
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
@addaleax addaleax mentioned this pull request Jul 11, 2017
Merged
addaleax pushed a commit that referenced this pull request Jul 18, 2017
@Trott @addaleax
test: skip test-fs-readdir-ucs2 if no support
d288cf1 
If the filesystem does not support UCS2, do not run the test.

PR-URL: #14029
Fixes: #14028
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Fishrock123 pushed a commit that referenced this pull request Jul 19, 2017
@Trott @Fishrock123
test: skip test-fs-readdir-ucs2 if no support
e583e3b 
If the filesystem does not support UCS2, do not run the test.

PR-URL: #14029
Fixes: #14028
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
MylesBorins pushed a commit that referenced this pull request Aug 15, 2017
@Trott @MylesBorins
test: skip test-fs-readdir-ucs2 if no support
c57a786 
If the filesystem does not support UCS2, do not run the test.

PR-URL: #14029
Fixes: #14028
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Trott added a commit to Trott/io.js that referenced this pull request Aug 15, 2017
@Trott
test: skip test-fs-readdir-ucs2 if no support
f41047e 
If the filesystem does not support UCS2, do not run the test.

PR-URL: nodejs#14029
Fixes: nodejs#14028
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
MylesBorins pushed a commit that referenced this pull request Aug 16, 2017
@Trott @MylesBorins
test: skip test-fs-readdir-ucs2 if no support
175d46e 
If the filesystem does not support UCS2, do not run the test.

Backport-PR-URL: #14835
PR-URL: #14029
Fixes: #14028
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Aug 16, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Sep 5, 2017
@Trott @MylesBorins
test: skip test-fs-readdir-ucs2 if no support
46e4a02 
If the filesystem does not support UCS2, do not run the test.

Backport-PR-URL: #14835
PR-URL: #14029
Fixes: #14028
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
This was referenced Sep 5, 2017
Closed
Closed
Closed
Closed
Closed
@refack refack removed their assignment Oct 20, 2018
@Trott Trott deleted the fix-ucs2-test branch January 13, 2022 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardlau richardlau richardlau approved these changes

@cjihrig cjihrig cjihrig approved these changes

@lpinca lpinca lpinca approved these changes

@refack refack refack approved these changes

Assignees
No one assigned
Labels
test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

investigate failing test-fs-readdir-ucs2 on Raspberry Pi
7 participants
@Trott @refack @lpinca @cjihrig @richardlau @MylesBorins @nodejs-github-bot