Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

assert: improve performance #13973

Closed
wants to merge 3 commits into from
Closed

assert: improve performance #13973

wants to merge 3 commits into from

Commits on Jul 8, 2017

  1. benchmark: fix and extend assert benchmarks 

    The benchmarks had the strict and non strict labels switched.
This is fixed and the benchmarks were extended to check more
possible input types and function calls.
    @BridgeAR
    BridgeAR committed Jul 8, 2017
    Configuration menu
    Copy the full SHA
    7727eeb View commit details
    Browse the repository at this point in the history

  2. assert: refactor to reduce unecessary code paths 

    The lazy loading is not needed as the errors themself lazy
load assert. Therefore the circle is working as intended
even without this lazy loading.

Improve Array, object, ArrayBuffer, Set and Map performance
in all deepEqual checks by removing unecessary code paths and
by moving expensive checks further back.

Improve throws and doesNotThrow performance by removing dead
code and simplifying the overall logic.
    @BridgeAR
    BridgeAR committed Jul 8, 2017
    Configuration menu
    Copy the full SHA
    a3e6194 View commit details
    Browse the repository at this point in the history

  3. test: remove obsolete argument 

    assert.strictEqual can either have two or three arguments, not four.
    @BridgeAR
    BridgeAR committed Jul 8, 2017
    Configuration menu
    Copy the full SHA
    6e456f1 View commit details
    Browse the repository at this point in the history